[19.0][MIG][ADD] hr_timesheet_begin_end_break - #943
Open
bosd wants to merge 2 commits into
Open
Conversation
Add a break duration field on begin/end timesheet lines, deducted from the worked hours: unit_amount = time_stop - time_start - break_duration. Squashed takeover of OCA/timesheet PR OCA#853, with review fixes: English-only test comments, fragmented readme/ fragments, and a documented rationale for overriding the base begin/end duration constraint. Co-authored-by: Stefano Consolaro <stefano.consolaro@mymage.it>
OCA-git-bot
added
series:19.0
mod:hr_timesheet_begin_end_break
bosd
changed the title
- Bump manifest to 19.0.1.0.0 and depend on hr_timesheet_begin_end only. - Align the duration/overlap constraint with the 19.0 base implementation (env._, float_time value_to_html, precision_rounding, simplified overlap domain), keeping break_duration in the duration expectation. - Add the break field to the embedded task timesheet form sub-view. - Add OCA icon, generate README.rst from fragments, add i18n .pot.
bosd
force-pushed
the
19.0-timesheet-begin-end-break
branch
from
July 15, 2026 21:04
ed26ce7 to
24cdad4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over and forward-ports #853 to 19.0.
What
Adds
hr_timesheet_begin_end_break, extendinghr_timesheet_begin_endwith abreak_durationfield that is deducted from the worked hours:unit_amount = time_stop - time_start - break_duration.Commits
[ADD]— squashed takeover of [ADD] hr_timesheet_begin_end_break: Add break duration field. #853, authored by the original author(Slivi-sliv), with the review comments addressed (English-only test
comments, fragmented
readme/, documented constraint override).[MIG]— migration to 19.0: version bump, constraint aligned with the 19.0base implementation, break field added to the task timesheet sub-view form,
OCA icon,
.pot, and a demo-independent test fixture.