[18.0][FIX] hr_timesheet_sheet_attendance: make _check_timesheet multi-record safe - #947
Open
renzo1974 wants to merge 1 commit into
Open
Conversation
…rd safe The constraint read self.sheet_id and self.check_in directly on the recordset. Odoo passes the whole affected recordset to @api.constrains, so creating or writing several attendances at once raised "ValueError: Expected singleton" as soon as a timesheet sheet covered the period - hitting list view multi-edit, imports and any module that creates attendances in batch. Worse, on create the error is raised after the rows are inserted, so a caught exception leaves the attendances in place while everything hooked after core create is skipped. Iterate over self and add a regression test covering both the valid batch and a batch containing one offending record.
OCA-git-bot
added
mod:hr_timesheet_sheet_attendance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constraint read self.sheet_id and self.check_in directly on the recordset.
Odoo passes the whole affected recordset to @api.constrains, so creating or writing several attendances at once raised "ValueError: Expected singleton" as soon as a timesheet sheet covered the period - hitting list view multi-edit, imports and any module that creates attendances in batch.
Worse, on create the error is raised after the rows are inserted, so a caught exception leaves the attendances in place while everything hooked after core create is skipped.
Iterate over self and add a regression test covering both the valid batch and a batch containing one offending record.