Skip to content

[18.0][MIG] web_widget_one2many_tree_line_duplicate: Migration to 18.0#3250

Merged
OCA-git-bot merged 11 commits intoOCA:18.0from
ForgeFlow:18.0-mig-web_widget_one2many_tree_line_duplicate
Sep 18, 2025
Merged

[18.0][MIG] web_widget_one2many_tree_line_duplicate: Migration to 18.0#3250
OCA-git-bot merged 11 commits intoOCA:18.0from
ForgeFlow:18.0-mig-web_widget_one2many_tree_line_duplicate

Conversation

@ArnauCForgeFlow
Copy link
Copy Markdown
Contributor

@ArnauCForgeFlow ArnauCForgeFlow commented Aug 13, 2025

Migration to 18.0

Tardo and others added 10 commits August 7, 2025 14:26
@Tardo @ArnauCForgeFlow
[ADD] web_widget_one2many_tree_line_duplicate
a0f68e6
@Tardo @ArnauCForgeFlow
[IMP] web_widget_one2many_tree_line_duplicate: Clone all fields
aaad549
@chienandalu @ArnauCForgeFlow
[FIX] web_widget_one2many_tree_line_duplicate: clone wisely
940e915 
- When we clone a line, we can be interested in preloading those fields
availiable in other field views available. Otherwise, we could be unable
to get the proper states in the cloned line.
- When we load the cloned field values from the rpc method, we must
discard those fields not available in the views or some subproccess
could try to get their state causing errors.

TT38191
@chienandalu @ArnauCForgeFlow
[FIX] web_widget_one2many_tree_line_duplicate: cloned record relations
79bfba2 
On the cloned record we were unable to change the values of the
relational fields we we just had edited it. Here is solved adding a
pseudo onchange method that triggers the proper refreshed values as if
the record was made manually.

TT38191
@CarlosRoca13 @ArnauCForgeFlow
[IMP] web_widget_one2many_tree_line_duplicate: pre-commit stuff
f4343cc
@CarlosRoca13 @ArnauCForgeFlow
[MIG] web_widget_one2many_tree_line_duplicate: Migration to 16.0
fa0a3b2
@ArnauCForgeFlow
[UPD] Update web_widget_one2many_tree_line_duplicate.pot
d6d7860
@mymage @ArnauCForgeFlow
Added translation using Weblate (Italian)
c1e0a9d
@mymage @ArnauCForgeFlow
Translated using Weblate (Italian)
8cdff65 
Currently translated at 100.0% (1 of 1 strings)

Translation: web-16.0/web-16.0-web_widget_one2many_tree_line_duplicate
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_one2many_tree_line_duplicate/it/
@ArnauCForgeFlow
[IMP] web_widget_one2many_tree_line_duplicate: pre-commit auto fixes
fcd71c1
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Aug 13, 2025

/ocabot migration web_widget_one2many_tree_line_duplicate

Please @CarlosRoca13 check if the one2many nested into another one2many is working with this migration.

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 13, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 13, 2025
Open
46 tasks
CarlosRoca13
CarlosRoca13 requested changes Aug 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArnauCForgeFlow , thanks for the work done, but there are still a couple of things to polish:

It seems that the price is not being transferred from one line to the other.
Ejemplo precios

There is a shift in the delete-line icon that makes it appear off-screen.
ejemplo_desplazamiento

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-web_widget_one2many_tree_line_duplicate branch from 410953e to f491d3d Compare August 18, 2025 13:51
@ArnauCForgeFlow
Copy link
Copy Markdown
Contributor Author

ArnauCForgeFlow commented Aug 18, 2025

@CarlosRoca13 both problems should be fixed now, could you check again? thanks!

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

LoisRForgeFlow commented Sep 2, 2025

@CarlosRoca13 A kind reminder here, could you check if it looks good now?

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-web_widget_one2many_tree_line_duplicate branch from f491d3d to 662849b Compare September 2, 2025 11:31
@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-mig-web_widget_one2many_tree_line_duplicate branch from 662849b to e6219a9 Compare September 2, 2025 13:02
pedrobaeza
pedrobaeza approved these changes Sep 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 18, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3250-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 18, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 8aa223e into OCA:18.0 Sep 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 18, 2025

Congratulations, your PR was merged at 00c5a2f. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 18.0-mig-web_widget_one2many_tree_line_duplicate branch September 22, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

8 participants

@ArnauCForgeFlow @pedrobaeza @LoisRForgeFlow @OCA-git-bot @CarlosRoca13 @Tardo @chienandalu @mymage