Skip to content

[18.0][FIX] web_company_color: fix systray icon color#3268

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
ForgeFlow:18.0-fix-web_company_color-menu_color
Sep 8, 2025
Merged

[18.0][FIX] web_company_color: fix systray icon color#3268
OCA-git-bot merged 1 commit intoOCA:18.0from
ForgeFlow:18.0-fix-web_company_color-menu_color

Conversation

@ArnauCForgeFlow
Copy link
Copy Markdown
Contributor

In Odoo 17 the classes were nested, so the descendant selector worked, but in Odoo 18 both classes are on the same element.

Before:
image

After:
image

@pedrobaeza pedrobaeza added this to the 18.0 milestone Sep 1, 2025
Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better!

There are some icons that still do not keep color:

image

One is the QR search icon from the module document_quick_access, the other is the odoo studio icon.

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-fix-web_company_color-menu_color branch from fc7d622 to 48bd451 Compare September 2, 2025 10:40
@ArnauCForgeFlow
Copy link
Copy Markdown
Contributor Author

@LoisRForgeFlow Fixed!

Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👌

Copy link
Copy Markdown
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3268-by-StefanRijnhart-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 3, 2025
Signed-off-by StefanRijnhart
@OCA-git-bot
Copy link
Copy Markdown
Contributor

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-3268-by-StefanRijnhart-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@StefanRijnhart
Copy link
Copy Markdown
Member

@ArnauCForgeFlow Do you know why this seemed to fix the tests on the PR but does not fix the tests during the merge?

2025-09-04 07:52:16,624 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui.browser: console.groupEnd 
2025-09-04 07:52:16,625 294 ERROR odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui.browser: FAILED: [3/5] Tour web_systray_button_init_action_set_tour → Step .o_app[data-menu-xmlid='base.menu_administration'].
Element (.o_app[data-menu-xmlid='base.menu_administration']) has not been found.
TIMEOUT step failed to complete within 10000 ms. 
2025-09-04 07:52:16,625 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Asking for screenshot 
2025-09-04 07:52:16,627 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui.browser: Error received after termination: {
  "trigger": ".init_action_div:has(button[name='init_action'])"
},
{
  "isActive": [
    "auto",
    "community",
    "desktop"
  ],
  "trigger": ".o_navbar_apps_menu button:enabled",
  "run": "click",
  "tooltipPosition": "bottom"
},
---------- FAILED: [3/5] Tour web_systray_button_init_action_set_tour → Step .o_app[data-menu-xmlid='base.menu_administration'] ----------
{
  "trigger": ".o_app[data-menu-xmlid='base.menu_administration']",
  "run": "click"
},
------------------------------------------------------------------------------------------------------------------------------------------
{
  "trigger": "button[name='init_action']",
  "run": "click"
},
{
  "trigger": ".o_last_breadcrumb_item:has(span:contains('Apps'))"
}, 
2025-09-04 07:52:16,627 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Asking for screenshot 
2025-09-04 07:52:16,836 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Screenshot in: /tmp/odoo_tests/odoo/screenshots/sc_20250904_075216_835474_TestUI.png 
2025-09-04 07:52:16,965 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Closing chrome headless with pid 1161 
2025-09-04 07:52:16,966 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Screenshot in: /tmp/odoo_tests/odoo/screenshots/sc_20250904_075216_965277_TestUI.png 
2025-09-04 07:52:16,966 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Closing websocket connection 
2025-09-04 07:52:16,967 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Terminating chrome headless with pid 1161 
2025-09-04 07:52:16,999 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: Removing chrome user profile "/tmp/tmpt6xnx51x_chrome_odoo" 
2025-09-04 07:52:17,018 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action.TestUI.test_ui: waiting for threads: [] 
2025-09-04 07:52:17,019 294 INFO odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action: ====================================================================== 
2025-09-04 07:52:17,019 294 ERROR odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action: FAIL: TestUI.test_ui
Traceback (most recent call last):
  File "/__w/web/web/web_systray_button_init_action/tests/test_web_systray_button_init_action.py", line 20, in test_ui
    self.start_tour(
  File "/opt/odoo/odoo/tests/common.py", line 2266, in start_tour
    return self.browser_js(url_path=url_path, code=code, ready=ready, timeout=timeout, success_signal="tour succeeded", **kwargs)
  File "/opt/odoo/odoo/tests/common.py", line 2240, in browser_js
    self.fail('%s\n\n%s' % (message, error))
AssertionError: The test code "odoo.startTour('web_systray_button_init_action_set_tour', {"stepDelay": 100, "keepWatchBrowser": false, "debug": false, "startUrl": "/web", "delayToCheckUndeterminisms": 0})" failed

FAILED: [3/5] Tour web_systray_button_init_action_set_tour → Step .o_app[data-menu-xmlid='base.menu_administration'].
Element (.o_app[data-menu-xmlid='base.menu_administration']) has not been found.
TIMEOUT step failed to complete within 10000 ms.

@ArnauCForgeFlow ArnauCForgeFlow force-pushed the 18.0-fix-web_company_color-menu_color branch from 48bd451 to c12559e Compare September 4, 2025 10:24
@ArnauCForgeFlow
Copy link
Copy Markdown
Contributor Author

@StefanRijnhart The PR was passing before because it was outdated, but after rebasing it, fails like the other PRs.

@StefanRijnhart
Copy link
Copy Markdown
Member

Oh I was mislead by seeing systray in the title 🤦

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

@ArnauCForgeFlow can you rebase here to include the change on rebel modules? or is the problem with CI here related to other topic?

@pedrobaeza
Copy link
Copy Markdown
Member

No need to rebase, as the bot does it:

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3268-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f227151 into OCA:18.0 Sep 8, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 6719362. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 18.0-fix-web_company_color-menu_color branch September 8, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants