Skip to content

[18.0][REF] web_responsive: set as rebel module#3275

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
StefanRijnhart:18.0-ci-web_responsive-rebel_module
Sep 5, 2025
Merged

[18.0][REF] web_responsive: set as rebel module#3275
OCA-git-bot merged 1 commit intoOCA:18.0from
StefanRijnhart:18.0-ci-web_responsive-rebel_module

Conversation

@StefanRijnhart
Copy link
Copy Markdown
Member

@StefanRijnhart StefanRijnhart commented Sep 4, 2025

web_tour's showAppsMenuItem does not work with web_responsive, causing

 2025-09-04 07:52:17,019 294 ERROR odoo odoo.addons.web_systray_button_init_action.tests.test_web_systray_button_init_action: FAIL: TestUI.test_ui
Traceback (most recent call last):
  File "/__w/web/web/web_systray_button_init_action/tests/test_web_systray_button_init_action.py", line 20, in test_ui
    self.start_tour(
  File "/opt/odoo/odoo/tests/common.py", line 2266, in start_tour
    return self.browser_js(url_path=url_path, code=code, ready=ready, timeout=timeout, success_signal="tour succeeded", **kwargs)
  File "/opt/odoo/odoo/tests/common.py", line 2240, in browser_js
    self.fail('%s\n\n%s' % (message, error))
AssertionError: The test code "odoo.startTour('web_systray_button_init_action_set_tour', {"stepDelay": 100, "keepWatchBrowser": false, "debug": false, "startUrl": "/web", "delayToCheckUndeterminisms": 0})" failed

FAILED: [3/5] Tour web_systray_button_init_action_set_tour → Step .o_app[data-menu-xmlid='base.menu_administration'].
Element (.o_app[data-menu-xmlid='base.menu_administration']) has not been found.
TIMEOUT step failed to complete within 10000 ms.

@StefanRijnhart StefanRijnhart changed the title [REF] web_responsive: set as rebel module [18.0][REF] web_responsive: set as rebel module Sep 4, 2025
@StefanRijnhart StefanRijnhart force-pushed the 18.0-ci-web_responsive-rebel_module branch from e5a5b29 to 98d4232 Compare September 4, 2025 22:44
@StefanRijnhart StefanRijnhart force-pushed the 18.0-ci-web_responsive-rebel_module branch from 98d4232 to 0b5aa67 Compare September 4, 2025 22:48
@StefanRijnhart StefanRijnhart marked this pull request as ready for review September 4, 2025 22:56
@pedrobaeza
Copy link
Copy Markdown
Member

@CarlosRoca13 is there any possible solution apart from this one. Note that the problem is only when merging, not on PRs.

@StefanRijnhart
Copy link
Copy Markdown
Member Author

@pedrobaeza it is also on PRs.

@CarlosRoca13
Copy link
Copy Markdown
Contributor

I'm trying to reproduce it locally but i can't...

Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's move on then

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3275-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 60e96ff into OCA:18.0 Sep 5, 2025
9 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 60e96ff. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants