Fix CI in 14.0 by SirPyTech · Pull Request #3281 · OCA/web

SirPyTech · 2025-09-09T15:18:17Z

We have noticed that the tests in 14.0 are failing, this is a known issue for (at least one of) @OCA/web-maintainers:

old js tests are a mess, and I've given up trying to fix them

Originally posted by @hbrunn in #2433 (review)

I have managed to fix one of the failures but can't reproduce the others, like:

2025-09-04 20:15:20,723 550 ERROR odoo odoo.addons.web_disable_export_group.tests.test_tour: FAIL: TestTour.test_user_not_export
Traceback (most recent call last):
  File "/__w/web/web/web_disable_export_group/tests/test_tour.py", line 30, in test_user_not_export
    self.start_tour("/web", "export_tour_xlsx_button_ko", login="user_not_export")
  File "/opt/odoo/odoo/tests/common.py", line 1563, in start_tour
    res = self.browser_js(url_path=url_path, code=code, ready=ready, **kwargs)
  File "/opt/odoo/odoo/tests/common.py", line 1535, in browser_js
    self.assertTrue(self.browser._wait_ready(ready), 'The ready "%s" code was always falsy' % ready)
AssertionError: False is not true : The ready "odoo.__DEBUG__.services['web_tour.tour'].tours['export_tour_xlsx_button_ko'].ready" code was always falsy

(from https://github.com/OCA/web/actions/runs/17475451661/job/49634125811#step:8:674)

Does anybody have a clue?
Looks like all the failing tests are from module web_disable_export_group, should we disable them?

Let me know what you think, thanks!

Stack of error happening before this change: 2025-08-28 06:19:26,925 550 ERROR odoo odoo.tests.loader: Can not `import web_edit_user_filter`. Traceback (most recent call last): File "/opt/odoo/odoo/tests/loader.py", line 29, in _get_tests_modules mod = importlib.import_module('.tests', modpath) File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 994, in _gcd_import File "<frozen importlib._bootstrap>", line 971, in _find_and_load File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 665, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 678, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/__w/web/web/web_edit_user_filter/tests/__init__.py", line 1, in <module> from . import test_edit_user_filter File "/__w/web/web/web_edit_user_filter/tests/test_edit_user_filter.py", line 4, in <module> from odoo.tests.common import SingleTransactionCase, post_install ImportError: cannot import name 'post_install'

francesco-ooops · 2025-09-11T09:26:45Z

@OCA/web-maintainers could you please take a look? Thanks!

etobella

/ocabot merge patch

OCA-git-bot · 2025-09-11T09:28:17Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3281-by-etobella-bump-patch, awaiting test results.

Signed-off-by etobella

OCA-git-bot · 2025-09-11T09:34:31Z

@etobella your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3281-by-etobella-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

francesco-ooops · 2025-09-11T09:57:00Z

Looks like all the failing tests are from module web_disable_export_group, should we disable them?

@etobella

hbrunn · 2025-09-12T04:40:14Z

thanks for looking into this. Disabling a test should be a last resort, first try to change /web into /web?debug=tests in

https://github.com/OCA/web/blob/14.0/web_disable_export_group/tests/test_tour.py#L27

and following.

I wonder why you can't reproduce this? Do you possibly not have the websocket library and/or chrome installed on your dev machine? Then -i web_disable_export_group --test-enable should give you a warning to that effect.

etobella · 2025-09-12T05:14:55Z

Quite funny, I made a PR to execute the module independently, and it gave the same error. However, in local the tests are executed.

It seems that the problem comes from here:

https://github.com/OCA/web/actions/runs/17665134973/job/50205409179?pr=3283#step:8:60

So, when it is making the first connection, it fails, but locally, it works as expected:

hbrunn · 2025-09-12T06:00:29Z

oh nice catch. Might be an issue with how v14 acts on github, as it looks like this is the only v14 js test. Could you try if requests.get('http://127.0.0.1:8069/web') actually returns a result before start_tour?

etobella · 2025-09-12T06:41:31Z

It seems that it doesn't work, but why???

hbrunn · 2025-09-12T06:46:07Z

what error does the requests module return? timeout, connection refused, ...?

etobella · 2025-09-12T07:09:52Z

Aborted.

2025-09-12 05:09:14,813 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Chrome pid: 561
2025-09-12 05:09:14,819 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Issuing json command http://127.0.0.1:36041/json/version
2025-09-12 05:09:14,842 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Browser version: Chrome/139.0.7258.127
2025-09-12 05:09:14,843 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Issuing json command http://127.0.0.1:36041/json
2025-09-12 05:09:14,856 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Chrome headless temporary user profile dir: /tmp/tmphkg6x4w1_chrome_odoo
2025-09-12 05:09:14,857 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Websocket url found: ws://127.0.0.1:36041/devtools/page/CD6B8E45886C1EC318B843457213ADCA
2025-09-12 05:09:14,860 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Enable chrome headless console log notification
2025-09-12 05:09:14,860 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Chrome headless enable page notifications
2025-09-12 05:09:14,934 550 INFO odoo odoo.addons.base.models.res_users: Login successful for db:odoo login:admin from n/a
2025-09-12 05:09:14,936 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Setting session cookie in browser
2025-09-12 05:09:14,940 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Open "http://127.0.0.1:8069/web" in browser
2025-09-12 05:09:14,941 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Navigating to: "http://127.0.0.1:8069/web"
2025-09-12 05:09:14,944 550 INFO odoo odoo.addons.web_disable_export_group.tests.test_tour.TestTour: Navigation result: {'id': 3, 'result': {'frameId': 'CD6B8E45886C1EC318B843457213ADCA', 'loaderId': '8C964346022E30AACF6921088E4B4A73', 'errorText': 'net::ERR_ABORTED'}}

hbrunn · 2025-09-12T07:14:50Z

that's chrome's quite unhelpful error message, that's why I asked you to make a request yourself and see what you get back there

francesco-ooops · 2025-09-17T10:07:41Z

@hbrunn @etobella any update?

yvaucher · 2025-09-17T10:43:43Z

@francesco-ooops OCA/oca-ci#109 was merged just few minutes ago. Let's restart the CI jobs.

yvaucher · 2025-09-17T12:37:27Z

All green, let's merge 🚀

yvaucher · 2025-09-17T12:37:48Z

/ocabot merge patch

OCA-git-bot · 2025-09-17T12:37:56Z

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3281-by-yvaucher-bump-patch, awaiting test results.

Signed-off-by yvaucher

OCA-git-bot · 2025-09-17T12:44:10Z

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-3281-by-yvaucher-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yvaucher · 2025-09-17T13:05:19Z

Still failing on only one test, I misread the list of checks. There is progress.

yvaucher · 2025-09-17T13:19:03Z

The last error seems related to the ci images not properly built in some case. More on #odoo-ci/109

SirPyTech · 2025-09-17T14:06:38Z

/ocabot merge patch

Please try again, all the builds are green now in https://github.com/OCA/oca-ci.
Thanks for your work 🙏

yvaucher · 2025-09-17T14:08:24Z

/ocabot merge patch

OCA-git-bot · 2025-09-17T14:08:31Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-3281-by-yvaucher-bump-patch, awaiting test results.

OCA-git-bot · 2025-09-17T14:12:10Z

Congratulations, your PR was merged at 226b172. Thanks a lot for contributing to OCA. ❤️

etobella approved these changes Sep 11, 2025

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Sep 11, 2025

Merge PR #3281 into 14.0

260771a

Signed-off-by etobella

OCA-git-bot added the bot is merging ⏳ label Sep 11, 2025

OCA-git-bot removed the bot is merging ⏳ label Sep 11, 2025

etobella mentioned this pull request Sep 12, 2025

[14.0][FIX] CI #3283

Open

OCA-git-bot added a commit that referenced this pull request Sep 17, 2025

Merge PR #3281 into 14.0

c7acbe3

Signed-off-by yvaucher

OCA-git-bot added the bot is merging ⏳ label Sep 17, 2025

OCA-git-bot removed the bot is merging ⏳ label Sep 17, 2025

OCA-git-bot added the bot is merging ⏳ label Sep 17, 2025

OCA-git-bot merged commit 20fff6b into OCA:14.0 Sep 17, 2025
15 of 19 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 17, 2025

Uh oh!

Conversation

SirPyTech commented Sep 9, 2025

Uh oh!

francesco-ooops commented Sep 11, 2025

Uh oh!

etobella left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Sep 11, 2025

Uh oh!

OCA-git-bot commented Sep 11, 2025

Uh oh!

francesco-ooops commented Sep 11, 2025

Uh oh!

hbrunn commented Sep 12, 2025

Uh oh!

etobella commented Sep 12, 2025

Uh oh!

hbrunn commented Sep 12, 2025

Uh oh!

etobella commented Sep 12, 2025

Uh oh!

hbrunn commented Sep 12, 2025

Uh oh!

etobella commented Sep 12, 2025

Uh oh!

hbrunn commented Sep 12, 2025

Uh oh!

francesco-ooops commented Sep 17, 2025

Uh oh!

yvaucher commented Sep 17, 2025

Uh oh!

yvaucher commented Sep 17, 2025

Uh oh!

yvaucher commented Sep 17, 2025

Uh oh!

OCA-git-bot commented Sep 17, 2025

Uh oh!

OCA-git-bot commented Sep 17, 2025

Uh oh!

yvaucher commented Sep 17, 2025

Uh oh!

yvaucher commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SirPyTech commented Sep 17, 2025

Uh oh!

yvaucher commented Sep 17, 2025

Uh oh!

OCA-git-bot commented Sep 17, 2025

Uh oh!

OCA-git-bot commented Sep 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yvaucher commented Sep 17, 2025 •

edited

Loading