[18.0][FIX] Add !default to all color variable definitions#3294
Closed
[18.0][FIX] Add !default to all color variable definitions#3294
Conversation
Contributor
|
Hi @legalsylvain, |
DavidJForgeFlow
approved these changes
Sep 29, 2025
Member
Author
|
After further thought, I have decided to build a full dark theme for this module rather than trying to override things from web_dark_mode. I will open a pull request for this soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow web_dark_mode or any other theme to override colors defined here.
This is especially necessary for the
$input-background-color-requiredvariable because it looks hideous in a dark theme as mentioned by mathben in #3267@legalsylvain