[19.0][MIG] web_chatter_position: Migration to 19.0 by BhaveshHeliconia · Pull Request #3325 · OCA/web

BhaveshHeliconia · 2025-10-17T07:34:33Z

No description provided.

DucTruongKomit

I tested, no application error and any wrong so far.
Could you help to solve pre-commit and squash commit, please? @BhaveshHeliconia

quoc-pn · 2026-01-20T06:22:09Z

@BhaveshHeliconia I can not find the runboat instance to test, could you please help check? Thank you!

mailing module - Because the chatter in mass mailing form view lie under a notebook tab, if user choose sided chatter, it will disappear

[IMP] web_chatter_position: improve function compile web_chatter_position: propose myself as maintainer

BhaveshHeliconia · 2026-01-20T08:21:56Z

@quoc-pn : The Runboat instance is now up and running. You can test it now. Thanks!

quoc-pn · 2026-01-20T08:35:24Z

Hi @BhaveshHeliconia

The chatter width in “Sided” position is too large and reduces usable space when displaying large content.

I expect the width to be the same as the "Responsive" position.

BhaveshHeliconia · 2026-01-20T09:33:05Z

@quoc-pn : Good catch. I’ve fixed the issue and aligned the width with the “Responsive” position. Please check again. Thanks!

quoc-pn

Functional tested, LGTM!

quoc-pn · 2026-01-20T10:17:54Z

@BhaveshHeliconia

There are some commit made by Bots, please follow steps in the link below to clear them. Thank you!

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Check%20https%3A//github.com/OCA/maintainer%2Dtools/wiki/Merge%2Dcommits%2Din%2Dpull%2Drequests%20for%20a%20procedure%20for%20reducing%20commits%20from%20%22OCA%20Transbot...%22.

BhaveshHeliconia · 2026-01-20T10:32:46Z

@BhaveshHeliconia

There are some commit made by Bots, please follow steps in the link below to clear them. Thank you!

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Check%20https%3A//github.com/OCA/maintainer%2Dtools/wiki/Merge%2Dcommits%2Din%2Dpull%2Drequests%20for%20a%20procedure%20for%20reducing%20commits%20from%20%22OCA%20Transbot...%22.

@quoc-pn Done. Thanks!

fapruzzese-rapsodoo · 2026-02-04T17:14:42Z

web_chatter_position/__manifest__.py

    "license": "LGPL-3",
    "category": "Extra Tools",
-    "depends": ["web", "mail"],
+    "depends": ["web", "mail", "hr"],


Is it "hr" mandatory to have this feature?

Can you remove it? I don't think users want an useless module for this feature

Yes, I've removed it.

quoc-pn · 2026-02-09T04:58:49Z

@BhaveshHeliconia
There is improvement in v18 (#3183). Please help include those changes in this PR. Thank you!

Co-authored-by: Stefan Rijnhart <stefan@opener.amsterdam>

Currently translated at 100.0% (5 of 5 strings) Translation: web-18.0/web-18.0-web_chatter_position Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_chatter_position/fr_BE/

quoc-pn · 2026-02-11T07:25:08Z

web_chatter_position/static/src/js/web_chatter_position.esm.js

-        const chatterContainerXml = chatterContainerHookXml.querySelector(
-            "t[t-component='__comp__.mailComponents.Chatter']"
-        );
-        // Const chatterParent = chatterContainerXml.parentNode;


Did you reconsider these changes after applying the changes for branch 18.0?

Do we need to remove this code after applying the change from branch 18.0?

quoc-pn · 2026-02-11T07:25:17Z

web_chatter_position/static/src/js/web_chatter_position.esm.js

-        } else if (odoo.web_chatter_position === "sided") {
-            setAttributes(chatterContainerXml, {
-                isInFormSheetBg: `__comp__.uiService.size < ${SIZES.XXL}`,
-                isChatterAside: `__comp__.uiService.size >= ${SIZES.XXL}`,
-            });
-            setAttributes(chatterContainerHookXml, {
-                class: "o-mail-ChatterContainer o-mail-Form-chatter o-aside w-print-100",
-            });
-            // For "bottom", we keep the chatter in the form sheet
-            // (the one used for the attachment viewer case)
-            // If it's not there, we create it.


Did you reconsider these changes after applying the changes for branch 18.0?

Do we need to remove this code after applying the change from branch 18.0?

quoc-pn · 2026-02-11T07:25:25Z

web_chatter_position/static/src/js/web_chatter_position.esm.js

-                const sheetBgChatterContainerXml =
-                    sheetBgChatterContainerHookXml.querySelector(
-                        "t[t-component='__comp__.mailComponents.Chatter']"
-                    );
-
-                setAttributes(sheetBgChatterContainerXml, {
-                    isInFormSheetBg: "true",
-                });


Did you reconsider these changes after applying the changes for branch 18.0?

Do we need to remove this code after applying the change from branch 18.0?

quoc-pn · 2026-02-11T07:29:24Z

@BhaveshHeliconia
There are some commit made by Bots, please follow steps in the link below to clear them. Thank you!
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Check%20https%3A//github.com/OCA/maintainer%2Dtools/wiki/Merge%2Dcommits%2Din%2Dpull%2Drequests%20for%20a%20procedure%20for%20reducing%20commits%20from%20%22OCA%20Transbot...%22.

@quoc-pn Done. Thanks!

I think you need to redo this process.

landlogicit · 2026-02-12T10:48:35Z

Thanks for module web_chatter_position migrate to 19.x, good job

BhaveshHeliconia · 2026-02-20T05:02:45Z

@BhaveshHeliconia
There are some commit made by Bots, please follow steps in the link below to clear them. Thank you!
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Check%20https%3A//github.com/OCA/maintainer%2Dtools/wiki/Merge%2Dcommits%2Din%2Dpull%2Drequests%20for%20a%20procedure%20for%20reducing%20commits%20from%20%22OCA%20Transbot...%22.

@quoc-pn Done. Thanks!

I think you need to redo this process.

I’ve already done the process. There are no bot commits anymore.

quoc-pn

Please help resolve all reviews in the PR, thank you!

BhaveshHeliconia · 2026-04-10T06:34:47Z

@quoc-pn The code was removed because Odoo 19 (following the architecture introduced in v18) now natively handles chatter positioning logic.

Specifically, the mail module's native FormCompiler patch already identifies the Chatter component and dynamically sets the isInFormSheetBg and isChatterAside props based on the mailLayout() state.

Since super.compile() is called first, these attributes are already correctly configured by Odoo. Manually reapplying them here is not only redundant but could conflict with Odoo 19's native responsiveness, especially when handling the 'Combo' layout or attachment previews. Removing this logic ensures a cleaner integration and prevents potential UI bugs during layout transitions

BhaveshHeliconia mentioned this pull request Oct 17, 2025

Migration to version 19.0 #3295

Open

44 tasks

DucTruongKomit reviewed Nov 7, 2025

View reviewed changes

JuMiSanAr and others added 16 commits January 20, 2026 13:41

web_chatter_position: create module

c4eed73

[MIG] web_chatter_position: Migration to 16.0

cab68c4

Added translation using Weblate (Turkish)

692b938

Added translation using Weblate (French)

f860f88

Added translation using Weblate (Croatian)

4cdded1

Added translation using Weblate (Spanish)

306fdb9

Fixed JS assuming "o_form_sheet_bg" is always found

8299cd7

Added translation using Weblate (Dutch)

8f58349

Added translation using Weblate (Portuguese (Brazil))

c85d20e

[FIX] web_chatter_position: special case of sided chatter pos in mass

4b989e8

mailing module - Because the chatter in mass mailing form view lie under a notebook tab, if user choose sided chatter, it will disappear

Added translation using Weblate (Catalan)

90340ad

Added translation using Weblate (Italian)

cf926ba

Added translation using Weblate (German)

656a5a0

[IMP] web_chatter_position: pre-commit auto fixes

4db3787

[MIG] web_chatter_position: Migration to 17.0

3895ac4

[IMP] web_chatter_position: improve function compile web_chatter_position: propose myself as maintainer

[IMP] web_chatter_position: pre-commit auto fixes

8541d9f

BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch from 37130d2 to 7b41597 Compare January 20, 2026 08:11

BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch 2 times, most recently from 4614577 to cc5e080 Compare January 20, 2026 09:28

quoc-pn approved these changes Jan 20, 2026

View reviewed changes

[MIG] web_chatter_position: Migration to 18.0

9b07a5c

BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch from cc5e080 to b921fec Compare January 20, 2026 10:31

fapruzzese-rapsodoo reviewed Feb 4, 2026

View reviewed changes

MohamedOsman7 and others added 3 commits February 11, 2026 12:14

[IMP] web_chatter_position: improve form and chatter layout styles

d6d360d

Co-authored-by: Stefan Rijnhart <stefan@opener.amsterdam>

Added translation using Weblate (French (Belgium))

1d24f8f

Translated using Weblate (French (Belgium))

2499c09

Currently translated at 100.0% (5 of 5 strings) Translation: web-18.0/web-18.0-web_chatter_position Translate-URL: https://translation.odoo-community.org/projects/web-18-0/web-18-0-web_chatter_position/fr_BE/

BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch from b921fec to 049dba1 Compare February 11, 2026 06:47

quoc-pn reviewed Feb 11, 2026

View reviewed changes

BhaveshHeliconia requested review from DucTruongKomit and quoc-pn March 13, 2026 03:18

quoc-pn reviewed Mar 13, 2026

View reviewed changes

[MIG] web_chatter_position: Migration to 19.0

13ac70a

BhaveshHeliconia force-pushed the 19.0-mig-web_chatter_position branch from 049dba1 to 13ac70a Compare April 10, 2026 07:03

Uh oh!

Conversation

BhaveshHeliconia commented Oct 17, 2025

Uh oh!

DucTruongKomit left a comment

Choose a reason for hiding this comment

Uh oh!

quoc-pn commented Jan 20, 2026

Uh oh!

BhaveshHeliconia commented Jan 20, 2026

Uh oh!

quoc-pn commented Jan 20, 2026

Uh oh!

BhaveshHeliconia commented Jan 20, 2026

Uh oh!

quoc-pn left a comment

Choose a reason for hiding this comment

Uh oh!

quoc-pn commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BhaveshHeliconia commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quoc-pn commented Feb 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quoc-pn commented Feb 11, 2026

Uh oh!

landlogicit commented Feb 12, 2026

Uh oh!

BhaveshHeliconia commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quoc-pn left a comment

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

quoc-pn commented Jan 20, 2026 •

edited

Loading

BhaveshHeliconia commented Feb 20, 2026 •

edited

Loading