[19.0][MIG] web_widget_section_and_note_text_scrollable: Migration to 19.0 by yankinmax · Pull Request #3373 · OCA/web

yankinmax · 2025-11-25T17:28:22Z

No description provided.

jcoux

Code LGTM 👍

Don't forget to squash fixup

yankinmax · 2025-11-26T09:35:14Z

Hello @ivantodorovich
I need your help here. I've always a small "cell" size. Scrollable but small.

vvrossem · 2025-11-26T11:45:29Z

...ion_and_note_text_scrollable/static/src/product_label_section_and_note_field_scrollable.scss

+.o_field_product_label_section_and_note_field,
+.o_field_product_label_section_and_note_cell,
+.o_field_product_label_section_and_note_cell textarea {
+    height: auto !important;
+}


I'm a (s)css noob, but I think height is anyway redefined in o_field_product_label_section_and_note_cell and o_field_product_label_section_and_note_cell textarea below.

Suggested change

.o_field_product_label_section_and_note_field,

.o_field_product_label_section_and_note_cell,

.o_field_product_label_section_and_note_cell textarea {

height: auto !important;

}

.o_field_product_label_section_and_note_field {

height: auto !important;

}

imlopes · 2026-02-23T15:06:53Z

Hello @yankinmax
Could you check please the comment from Vincent?

Thanks.

yankinmax · 2026-02-26T06:54:00Z

Hello @imlopes
I would like to rebase and update this PR, but don't have time now.
If you're able to update this PR I would highly appreciate.

alexey-pelykh

Thanks for the migration, Maksym.

CSS class targeting looks correct for 19.0 -- the widget moved to account and uses o_field_product_label_section_and_note_field / o_field_product_label_section_and_note_cell now. The SCSS-only approach (no JS/OWL needed) is clean.

One minor note: the .pot file still says Project-Id-Version: Odoo Server 17.0 -- not blocking since the OCA bot regenerates it, but worth noting.

I'd echo vvrossem's observation on the first rule: the height: auto !important for .o_field_product_label_section_and_note_cell and its textarea is immediately overridden by the rules below, so narrowing that selector would trim some dead CSS. Not blocking either way.

LGTM overall.

OCA-git-bot · 2026-03-03T13:00:04Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

yankinmax · 2026-03-12T11:39:53Z

Hello @OCA/web-maintainers can you pls merge this PR?

yankinmax · 2026-03-16T12:40:48Z

Hello @etobella @hbrunn can you pls take a look at this PR and possibly merge?

ivantodorovich

Hey @yankinmax

It seems to work in edit mode, but not on read mode.

Moreover, in edit mode, it's moving the field as a column instead of keeping it below.. making the UI a bit weird. (possibly due to the display: flex)

Screen.Recording.2026-03-16.at.10.26.16.AM.mov

yankinmax · 2026-03-16T13:35:32Z

Hey @ivantodorovich
It was ok 😞
Thanks for checking! I'll take time to update!

ivantodorovich · 2026-03-16T13:37:10Z

I checked on runboat (Odoo CE)

Beware if you check on Odoo EE, sometimes different styles are applied.
However, the module must work on both versions.

yankinmax · 2026-03-26T13:01:00Z

Hello @ivantodorovich
This PR is fixed, thanks for the suggestion and check

vvrossem

code LGTM

yankinmax · 2026-03-30T07:28:21Z

Hello @ivantodorovich
Can you pls check this migration again and possibly trigger merge?

ivantodorovich

Thanks @yankinmax . Getting there

ivantodorovich · 2026-03-30T15:06:52Z

...ion_and_note_text_scrollable/static/src/product_label_section_and_note_field_scrollable.scss

+.o_field_product_label_section_and_note_cell textarea {
+    display: block;
+    width: 100%;
+    height: 10em !important;


Why forcing the height? I understand the max-height, cause that's the whole point of this module (have it scroll instead). But not this.

This is probably causing the following unwanted behavior.
Compare against standard Odoo here:

This PR runboat:
https://github.com/user-attachments/assets/2d6c1ca3-0969-4991-b168-9b329056d9e1

Odoo's runbot:
https://github.com/user-attachments/assets/c8bed633-957b-4d8e-8fde-4b016895512c

cc @alicedsp

@yankinmax , not sure to really understand why you pinged me here. Do you need a functional advice? Or is it to point me the issue we are facing?

Hello @alicedsp
I thought I've fixed the PR and I wanted you to make a functional review here.

@yankinmax , LGTM on the following runbot: [http://oca-web-19-0-pr3373-8533025579a0.runboat.odoo-community.org/odoo/discuss ]
A description can be added on the SO, if it is long the user will need to scroll to be able to see it completely in both display and edit mode.

ivantodorovich · 2026-03-30T15:10:40Z

...ion_and_note_text_scrollable/static/src/product_label_section_and_note_field_scrollable.scss

+    2. Don't change its height.
+*/
+.o_field_product_label_section_and_note_cell:not(:has(textarea)) {
+    display: block !important;


This seems redundant AFAICS

ivantodorovich · 2026-03-30T15:18:55Z

...ion_and_note_text_scrollable/static/src/product_label_section_and_note_field_scrollable.scss

+*/
+.o_field_product_label_section_and_note_cell:not(:has(textarea)) {
+    display: block !important;
+    max-height: 10em;


Maybe height: auto !important is needed here, too.

Cause I'm noticing some programmatical height style property being set, not sure from where, that's sometimes conflicting with the scroll -- assuming you remove the fixed height: 10em in the textarea, like suggested here: #3373 (comment)

Screen.Recording.2026-03-30.at.12.17.22.PM.mov

Not sure if height: auto is the best solution, but otherwise we need to investigate who's setting this fixed height and how it's computing it and why it's falling short -- cause if it were a few pixels taller we wouldn't have this issue.

yankinmax force-pushed the 19.0-mig-web_widget_section_and_note_text_scrollable branch 7 times, most recently from 48e5a8d to 11eeb7c Compare November 26, 2025 07:51

jcoux approved these changes Nov 26, 2025

View reviewed changes

yankinmax force-pushed the 19.0-mig-web_widget_section_and_note_text_scrollable branch from 11eeb7c to d0f5a48 Compare November 26, 2025 09:30

yankinmax force-pushed the 19.0-mig-web_widget_section_and_note_text_scrollable branch from d0f5a48 to 850b6b9 Compare November 26, 2025 09:42

vvrossem reviewed Nov 26, 2025

View reviewed changes

alexey-pelykh approved these changes Mar 3, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 3, 2026

yankinmax force-pushed the 19.0-mig-web_widget_section_and_note_text_scrollable branch from 850b6b9 to 39be420 Compare March 3, 2026 13:39

ivantodorovich suggested changes Mar 16, 2026

View reviewed changes

OCA-git-bot removed approved ready to merge labels Mar 16, 2026

ivantodorovich and others added 2 commits March 26, 2026 14:00

[ADD] web_widget_section_and_note_text_scrollable

02c127b

Added translation using Weblate (Italian)

e6eb8d8

yankinmax force-pushed the 19.0-mig-web_widget_section_and_note_text_scrollable branch 2 times, most recently from e2a3c5d to a1c8560 Compare March 26, 2026 12:54

[MIG] web_widget_section_and_note_text_scrollable: Migration to 19.0

8533025

yankinmax force-pushed the 19.0-mig-web_widget_section_and_note_text_scrollable branch from a1c8560 to 8533025 Compare March 26, 2026 13:00

vvrossem approved these changes Mar 26, 2026

View reviewed changes

ivantodorovich suggested changes Mar 30, 2026

View reviewed changes

Uh oh!

Conversation

yankinmax commented Nov 25, 2025

Uh oh!

jcoux left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Nov 26, 2025

Uh oh!

vvrossem Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

imlopes commented Feb 23, 2026

Uh oh!

yankinmax commented Feb 26, 2026

Uh oh!

alexey-pelykh left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 3, 2026

Uh oh!

yankinmax commented Mar 12, 2026

Uh oh!

yankinmax commented Mar 16, 2026

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Mar 16, 2026

Uh oh!

ivantodorovich commented Mar 16, 2026

Uh oh!

yankinmax commented Mar 26, 2026

Uh oh!

vvrossem left a comment

Choose a reason for hiding this comment

Uh oh!

yankinmax commented Mar 30, 2026

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

yankinmax Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

alicedsp Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

yankinmax Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

alicedsp Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ivantodorovich Mar 30, 2026 •

edited

Loading