Skip to content

[19.0] [MIG] web_widget_bokeh_chart#3480

Merged
OCA-git-bot merged 64 commits intoOCA:19.0from
ForgeFlow:19.0-mig-web_widget_bokeh_chart
Mar 27, 2026
Merged

[19.0] [MIG] web_widget_bokeh_chart#3480
OCA-git-bot merged 64 commits intoOCA:19.0from
ForgeFlow:19.0-mig-web_widget_bokeh_chart

Conversation

@PaulaMForgeFlow
Copy link
Copy Markdown

Standard migration

LoisRForgeFlow and others added 30 commits March 16, 2026 12:29
Includes some manual fixes to silent ESLint warnings.
@PaulaMForgeFlow
Copy link
Copy Markdown
Author

@DavidJForgeFlow could you review this migration?

Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On each Odoo migration of this module, we take the occasion to upgrade the bokeh library used. The latest is now 3.9.0.

Could you do that?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@PaulaMForgeFlow PaulaMForgeFlow force-pushed the 19.0-mig-web_widget_bokeh_chart branch from 64ef91e to 588209b Compare March 23, 2026 08:51
@DavidJForgeFlow
Copy link
Copy Markdown
Contributor

@PaulaMForgeFlow PaulaMForgeFlow force-pushed the 19.0-mig-web_widget_bokeh_chart branch from 588209b to 94beeea Compare March 23, 2026 10:55
@PaulaMForgeFlow PaulaMForgeFlow force-pushed the 19.0-mig-web_widget_bokeh_chart branch from 94beeea to c98640b Compare March 24, 2026 09:36
Copy link
Copy Markdown
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍

Copy link
Copy Markdown
Contributor

@DavidJForgeFlow DavidJForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review 👍 Thanks for updating the library version!

Copy link
Copy Markdown
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Sorry @LoisRForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@LoisRForgeFlow
Copy link
Copy Markdown
Contributor

@OCA/web-maintainers can you help merging here? Thanks!

@tarteo
Copy link
Copy Markdown
Member

tarteo commented Mar 27, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-3480-by-tarteo-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 23f3f71 into OCA:19.0 Mar 27, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 2a59f0d. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 19.0-mig-web_widget_bokeh_chart branch March 27, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.