[18.0][IMP] web_company_color: allow to set bottom border color of navbar#3484
Merged
OCA-git-bot merged 3 commits intoOCA:18.0from Mar 25, 2026
Merged
Conversation
pedrobaeza
approved these changes
Mar 19, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Thanks for this. I think the first commit should be [REF], not [FIX].
hbrunn
force-pushed
the
18.0-web_company_color-navbar-bottom
branch
from
7a944b6 to
d1b75f3
Compare
Member
Author
|
@pedrobaeza thanks for the headsup, fixed |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at cdd0e55. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odoo adds a 1px border below the nav bar, which is not visible below navbar buttons. Usually it's hard to notice because the colors are darkish, but when using web_company_color to set a bright color, it looks like this on current runbot:
but with this patch and setting the border color, it looks like this:
I took the liberty to simplify the code I had to touch anyways