[16.0][FIX] shopfloor_reception: Incorrect move line selection after partial receipt (without pack)#1125
Conversation
|
Hi @JuMiSanAr, @mmequignon, |
nicolas-delbovier-acsone
changed the title
|
We should use the field |
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-shopfloor_reception-without-pack-wrong-line-selected
branch
2 times, most recently
from
42f7e21 to
9a2d592
Compare
When users don't use packages for receptions, we should not rely only on its presence on lines to not select them. So, rely also on line progress completed at 100% (after split) to select another one with same criteria
… line has been fully processed.
Add a test case to verify that when multiple users are working on the same lot, one user cannot take the move line from another when scanning a lot.
nicolas-delbovier-acsone
force-pushed
the
16.0-fix-shopfloor_reception-without-pack-wrong-line-selected
branch
from
9a2d592 to
85b8ba5
Compare
…or "no user". A condition on the lines filtered lines has been added so to ensure that 2 users working on the same move do not steal move lines from one another.
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
@jbaudoux your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1125-by-jbaudoux-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 5c5644d. Thanks a lot for contributing to OCA. ❤️ |
4 participants
Problem
When performing a partial reception without packages, the system splits the stock.move.line into a completed line and a backorder line. Currently, the line selection logic incorrectly assumes that fully processed lines are the ones linked to a package. This causes the system to re-select the already-processed line (e.g., 3/3) instead of the remaining one (e.g., 0/7), blocking the completion of the transfer and causing data inconsistency.
Solution
Updated the move line selection logic to ensure that lines are selected based on the fact they have been completely processed or not.
This PR isolates and improves some change made in #1092 as to ease review (see this commit)