Merged
Conversation
luke-jr
reviewed
May 20, 2025
.github/workflows/build.yaml
Outdated
| config: | ||
| - cmake_args: "-DENABLE_API=ON -DCMAKE_C_COMPILER=gcc" | ||
| - cmake_args: "-DENABLE_API=ON -DCMAKE_C_COMPILER=clang" | ||
| - cmake_args: "-DENABLE_API=ON -DCMAKE_C_FLAGS=-DDATUM_API_FOR_UMBREL=ON" |
Contributor
There was a problem hiding this comment.
Do we know what compiler is used for Umbrel? Can we ensure we're using the same one for this build?
Member
Author
There was a problem hiding this comment.
It can be any, Umbrel use docker containers.
Contributor
There was a problem hiding this comment.
Version? Distro? Feels like this might be better to use https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#expanding-or-adding-matrix-configurations
Member
Author
There was a problem hiding this comment.
It use the latest version of GCC and Debian available at the build time so the actual workflow already cover that
Retropex
force-pushed
the
umbrel-api-workflow
branch
from
337744a to
2d10a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need #118 first