Skip to content

Bugfix: protocol: Enforce username length limit seeking into message #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luke-jr wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bugfix: protocol: Enforce username length limit seeking into message #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9463f72
Bugfix: protocol: Enforce username length limit seeking into message
luke-jr Apr 5, 2026
4c85eeb
Bugfix: protocol: Check for and handle (to the extent possible) snpri…
luke-jr Apr 5, 2026
bb9b25a
protocol: Remove redunant condition from final else block in datum_pr…
luke-jr Apr 5, 2026
d613935
protocol: Define and use DATUM_PROTOCOL_MAX_USERNAME_LEN
luke-jr Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/datum_protocol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,15 +1326,22 @@ int datum_protocol_pow(void *arg) {

char * const username = (char *)&msg[i];
if (((!datum_config.datum_pool_pass_full_users) && (!datum_config.datum_pool_pass_workers)) || pow->username[0] == '\0') {
i+=snprintf(username, 385, "%s", datum_config.mining_pool_address);
j = snprintf(username, DATUM_PROTOCOL_MAX_USERNAME_LEN + 1, "%s", datum_config.mining_pool_address);
} else if (datum_config.datum_pool_pass_full_users && pow->username[0] != '.') {
// TODO: Make sure the usernames are addresses, and if not use one of the configured addresses
i+=snprintf(username, 385, "%s", pow->username);
} else if (datum_config.datum_pool_pass_full_users || datum_config.datum_pool_pass_workers) {
j = snprintf(username, DATUM_PROTOCOL_MAX_USERNAME_LEN + 1, "%s", pow->username);
} else {
// append the miner's username to the configured address as .workername
i+=snprintf(username, 385, "%s%s%s", datum_config.mining_pool_address, (pow->username[0] == '.') ? "" : ".", pow->username);
j = snprintf(username, DATUM_PROTOCOL_MAX_USERNAME_LEN + 1, "%s%s%s", datum_config.mining_pool_address, (pow->username[0] == '.') ? "" : ".", pow->username);
}
if (j < 0) {
DLOG_ERROR("Unexpected error copying username to POW!");
Comment thread
luke-jr marked this conversation as resolved.
Comment thread
luke-jr marked this conversation as resolved.
// Still submit it without a username in case it's a block
username[0] = '\0';
j = 0;
}
Comment thread
luke-jr marked this conversation as resolved.
i++; // already 0 from snprintf
if (j > DATUM_PROTOCOL_MAX_USERNAME_LEN) j = DATUM_PROTOCOL_MAX_USERNAME_LEN;
i += j + 1; // including final null byte

// reserve 4 bytes for future use
memset(&msg[i], 0, 4); i+=4;
Expand Down
1 change: 1 addition & 0 deletions src/datum_protocol.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@

#define DATUM_PROTOCOL_MAX_CMD_DATA_SIZE 4194304 // 2^22 - protocol limit!
#define DATUM_PROTOCOL_BUFFER_SIZE (DATUM_PROTOCOL_MAX_CMD_DATA_SIZE*3)
#define DATUM_PROTOCOL_MAX_USERNAME_LEN 384

#define MAX_DATUM_CLIENT_EVENTS 32
Comment thread
luke-jr marked this conversation as resolved.

Expand Down
Loading