Skip to content

Implement failure handling in datum_coinbaser_init.#24

Closed
jesterhodl wants to merge 3 commits intoOCEAN-xyz:masterfrom
jesterhodl:datum_coinbaser_init-failure
Closed

Implement failure handling in datum_coinbaser_init.#24
jesterhodl wants to merge 3 commits intoOCEAN-xyz:masterfrom
jesterhodl:datum_coinbaser_init-failure

Conversation

@jesterhodl
Copy link
Copy Markdown
Contributor

No description provided.

@luke-jr luke-jr added the documentation Improvements or additions to documentation label Oct 21, 2024
Copy link
Copy Markdown
Contributor

@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should kill the entire process, not just log

@jesterhodl
Copy link
Copy Markdown
Contributor Author

jesterhodl commented Dec 29, 2024

Probably should kill the entire process, not just log

It will exit, because the caller of datum_coinbaser_init() is in datum_gateway.c and does exit(1):

        if (datum_coinbaser_init()) {
                DLOG_FATAL("Error initializing coinbaser thread");
                usleep(100000);
                exit(1);
        }

Or do you want to exit right away in datum_coinbaser_init() in datum_coinbaser.c?

@jesterhodl jesterhodl requested a review from luke-jr January 25, 2025 17:08
@luke-jr
Copy link
Copy Markdown
Contributor

luke-jr commented Mar 8, 2025

This was merged...

@luke-jr luke-jr closed this Mar 8, 2025
@jesterhodl jesterhodl deleted the datum_coinbaser_init-failure branch April 1, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants