Bugfix: Socket state can change between epoll and send#68
Merged
luke-jr merged 1 commit intoOCEAN-xyz:masterfrom Mar 7, 2025
Merged
Bugfix: Socket state can change between epoll and send#68luke-jr merged 1 commit intoOCEAN-xyz:masterfrom
luke-jr merged 1 commit intoOCEAN-xyz:masterfrom
Conversation
Dalaiyaz21213M
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Socket state can change and be improperly handled in the brief time between epoll and any send(...) from the application's client send buffer. Since this can lead to a SIGPIPE, despite the sockets being non-blocking, the gateway will exit without any descriptive error if this happens.
EPIPE is handled properly by existing datum_socket code.