Skip to content

Fix MacOS CI #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: gcos4gnucobol-3.x
Choose a base branch
from
Draft

Conversation

ddeclerck
Copy link
Contributor

@ddeclerck ddeclerck commented Mar 26, 2025

The MacOS CI has been down since the latest image update.
Apparently something to do with gettext.
Adding gettextize -f after the bootstrap step seems to solve the problem.

Copy link
Collaborator

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap script with install option should be changed instead

@@ -41,6 +41,7 @@ jobs:
- name: bootstrap
run: |
./build_aux/bootstrap install
gettextize -f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be autopoint -f, see https://lists.gnu.org/r/bug-gettext/2011-12/msg00001.html, but then...
Lets change the workflow to do ./autogen.sh install and the script ./build_aux/bootstrap to execute autopoint -f in case of "install" (before the other tools are executed).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems autopoint -f is not sufficient. gettextize -f updates more files (in particular the m4 macros).

@ddeclerck ddeclerck force-pushed the fix_macos_ci branch 2 times, most recently from 7b02bd7 to 579971e Compare March 26, 2025 13:36
@GitMensch
Copy link
Collaborator

From the CI output:

Copying file build_aux/config.rpath
Copying file m4/iconv.m4
Copying file po/Makefile.in.in
Copying file po/Makevars.template
Copying file po/Rules-quot
Copying file po/insert-header.sin
Copying file po/remove-potcdate.sin

vs.

Copying file ABOUT-NLS
Copying file build_aux/config.rpath
Copying file po/Makefile.in.in
Copying file po/Makevars.template
Copying file po/remove-potcdate.sed
Adding an entry to po/ChangeLog (backup is in po/ChangeLog~)
Copying file m4/build-to-host.m4
Copying file m4/gettext.m4
Copying file m4/host-cpu-c-abi.m4
Copying file m4/iconv.m4
Copying file m4/intlmacosx.m4
Copying file m4/lib-ld.m4
Copying file m4/lib-link.m4
Copying file m4/lib-prefix.m4
Copying file m4/nls.m4
Copying file m4/po.m4
Copying file m4/progtest.m4
Updating configure.ac (backup is in configure.ac~)
Adding an entry to ChangeLog (backup is in ChangeLog~)

Please run 'aclocal -I m4' to regenerate the aclocal.m4 file.
You need aclocal from GNU automake 1.9 (or newer) to do this.
Then run 'autoconf' to regenerate the configure file.

You might also want to copy the convenience header file gettext.h
from the /opt/homebrew/Cellar/gettext/0.24/share/gettext directory into your package.
It is a wrapper around <libintl.h> that implements the configure --disable-nls
option.

Press Return to acknowledge the previous two paragraphs.
/opt/homebrew/bin/gettextize: line 1310: /dev/tty: Device not configured

To drop the changelog parts we can use --no-changelog, but I'll try if dropping the gettext macro manually is enough.

test with explicit dropping the gettext macro
temp: debugging output
@GitMensch GitMensch marked this pull request as draft March 26, 2025 19:41
@GitMensch
Copy link
Collaborator

converting to draft as I want some input from gettext folks, mail to bug-gettext is on its way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants