Skip to content

Implement '--timeout' and '--timeout-instr' options, only in 'owi run` for now #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gasche
Copy link
Contributor

@gasche gasche commented May 15, 2025

See #155

(Powered by the Mirage retreat.)

@gasche
Copy link
Contributor Author

gasche commented May 15, 2025

Note: the timeout-instr instruction actually does not stop precisely at the number of instructions, but at the next multiple of 1024. We could refine the implementation to be more correct on smaller instruction counts.

@gasche gasche force-pushed the heartbeat branch 3 times, most recently from d9cd6c6 to fad1f95 Compare May 17, 2025 14:10
@zapashcanon
Copy link
Member

@gasche it looks like there is still an issue in doc/src/ocaml-api/overview.md (the new parameters are missing in the function call)

@zapashcanon
Copy link
Member

Thanks. I think you are missing a dune fmt and then this should be good to go! 😅

@zapashcanon
Copy link
Member

I'll run the benchmarks next week and then merge if there's no issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants