Implement '--timeout' and '--timeout-instr' options, only in 'owi run` for now #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the timeout-instr instruction actually does not stop precisely at the number of instructions, but at the next multiple of 1024. We could refine the implementation to be more correct on smaller instruction counts. |
gasche
force-pushed
the
heartbeat
branch
3 times, most recently
from
d9cd6c6 to
fad1f95
Compare
|
@gasche it looks like there is still an issue in |
|
Thanks. I think you are missing a |
|
I'll run the benchmarks next week and then merge if there's no issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #155
(Powered by the Mirage retreat.)