clean intf #863
Merged
clean intf #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redianthus
commented
Dec 13, 2025
|
|
||
| let eq e1 e2 = | ||
| if phys_equal e1 e2 then Symbolic_boolean.true_ else relop Ty_bool Eq e1 e2 | ||
| (* TODO: why do we use `Ty_bool` in the first two cases and `ty` in the others? What is the righe choice? *) |
Member
Author
There was a problem hiding this comment.
cc @filipeom, I can't make sense of this, could you explain how it works to me?
Collaborator
There was a problem hiding this comment.
Bitvectors use the default equality operator in SMTLIB (i.e., =). Since we pattern match on the theory to dispatch the operator we can just use Ty_bool for bitvectors to get the default boolean equality operator. But probably using ty would also work. Internally it defaults to the same operator used for Ty_bool.
redianthus
commented
Dec 13, 2025
| relop Ty_bool Eq e (of_concrete c) |> Symbolic_boolean.of_expr | ||
|
|
||
| let eq e1 e2 = | ||
| if phys_equal e1 e2 then Symbolic_boolean.true_ else relop Ty_bool Eq e1 e2 |
Member
Author
There was a problem hiding this comment.
cc @filipeom, I removed the phys_equal shortcut as it did not seem used that often to me and I also thinks it would make more sense to have it in smtml, WDYT?
Member
Author
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.