fix: checking for internet connection can timeout #1813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some CI environments or with low speed internet connections,
HAS_INTERNETwill return False due to aTimeoutError. This is a really rare bug. See DTCG logs here (requires authentication) and OGGM logs here.This fix speeds up the connection time by avoiding a DNS lookup and application layer connection through HTTP.
urlopenwill also return aTimeoutErrorif the DNS lookup fails.Points for discussion:
base_url. However, I don't recommend pinging the cluster every time someone runs a test.whats-new.rst