Skip to content

This package is preventing adding support for new SQL dialects #716

Closed
@schuemie

Description

@schuemie

One of the unit tests is to see if the generated SQL files match those that were pre-generated. This is done for all dialects supported by SqlRender as defined here. We just added the 'iris' dialect to SqlRender, which of course isn't one of the pre-rendered translations.

When I push SqlRender to CRAN, because CommonDataModel depends on SqlRender its unit tests are run with the new version. Because the pre-rendered SQL files do not contain the IRIS translations the unit tests fail and CRAN rejects the new SqlRender version.

In general I think this unit test is far too restrictive. It does not allow any changes to SqlRender. Even if the list of dialects stays the same, if SqlRender comes with a different but semantically equivalent translation it is blocked by CRAN. Please remove the unit test, or make it a lot more lenient.

Adding @bdeboe and @alex-odysseus for awareness of the first of probably many consequences of adding a new dialect.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions