Skip to content

Commit dcfcfe3

Browse files
committed
Fixes #121
Do not apply QualifiedLimitFilter when additional criteria is null.
1 parent e3cb494 commit dcfcfe3

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/org/ohdsi/webapi/cohortdefinition/CohortExpressionQueryBuilder.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,8 @@ public String buildExpressionQuery(CohortExpression expression, BuildExpressionQ
256256

257257
resultSql = StringUtils.replace(resultSql, "@QualifiedEventSort", (expression.qualifiedLimit.type != null && expression.qualifiedLimit.type.equalsIgnoreCase("LAST")) ? "DESC" : "ASC");
258258

259-
if (expression.qualifiedLimit.type != null && !expression.qualifiedLimit.type.equalsIgnoreCase("ALL"))
259+
// Only apply qualified limit filter if additional criteria is specified.
260+
if (expression.additionalCriteria != null && expression.qualifiedLimit.type != null && !expression.qualifiedLimit.type.equalsIgnoreCase("ALL"))
260261
{
261262
resultSql = StringUtils.replace(resultSql, "@QualifiedLimitFilter","WHERE QE.ordinal = 1");
262263
}

0 commit comments

Comments
 (0)