Skip to content

Commit eb370a5

Browse files
committed
Fixes #178
1 parent 9fd4f34 commit eb370a5

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

src/main/resources/resources/evidence/sql/getNegativeControls.sql

+8-4
Original file line numberDiff line numberDiff line change
@@ -186,8 +186,11 @@ WITH cte_concepts_of_interest AS
186186
CASE WHEN eu_spc IS NULL THEN 0 ELSE eu_spc END eu_spc,
187187
CASE WHEN spl_adr IS NULL THEN 0 ELSE spl_adr END spl_adr,
188188
CASE WHEN aers IS NULL THEN 0 ELSE aers END aers,
189-
CASE WHEN aers_prr IS NULL THEN 0 ELSE aers_prr END aers_prr
190-
FROM cte_complete_universe cu
189+
CASE WHEN aers_prr IS NULL THEN 0 ELSE aers_prr END aers_prr,
190+
se.in_universe
191+
FROM
192+
(SELECT CASE WHEN COUNT(*) > 0 THEN 1 ELSE 0 END in_universe FROM cte_summarize_evidence) se
193+
, cte_complete_universe cu
191194
FULL OUTER JOIN CTE_SUMMARIZE s ON s.@TARGET_DOMAIN_ID_CONCEPT_ID = cu.@TARGET_DOMAIN_ID_CONCEPT_ID
192195
), cte_summary_stdev AS (
193196
SELECT
@@ -204,8 +207,8 @@ WITH cte_concepts_of_interest AS
204207
, STDEV(spl_adr) spl_adr_stdev
205208
, STDEV(aers) aers_stdev
206209
, STDEV(aers_prr) aers_prr_stdev
207-
208210
FROM cte_summary
211+
WHERE cte_summary.in_universe = 1
209212
), cte_summary_scaled AS (
210213
SELECT
211214
concept_id
@@ -240,7 +243,8 @@ WITH cte_concepts_of_interest AS
240243

241244
FROM
242245
cte_summary, cte_summary_stdev
243-
246+
WHERE
247+
cte_summary.in_universe = 1
244248
), cte_model_applied AS (
245249
SELECT
246250
@CONCEPT_SET_ID concept_set_id

src/main/resources/resources/evidence/sql/getNegativeControlsSqlServer.sql

+9-4
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,12 @@ SELECT
199199
CASE WHEN eu_spc IS NULL THEN 0 ELSE eu_spc END eu_spc,
200200
CASE WHEN spl_adr IS NULL THEN 0 ELSE spl_adr END spl_adr,
201201
CASE WHEN aers IS NULL THEN 0 ELSE aers END aers,
202-
CASE WHEN aers_prr IS NULL THEN 0 ELSE aers_prr END aers_prr
202+
CASE WHEN aers_prr IS NULL THEN 0 ELSE aers_prr END aers_prr,
203+
se.in_universe
203204
INTO #summary
204-
FROM #complete_universe cu
205+
FROM
206+
(SELECT CASE WHEN COUNT(*) > 0 THEN 1 ELSE 0 END in_universe FROM #summarize_evidence) se
207+
, #complete_universe cu
205208
FULL OUTER JOIN CTE_SUMMARIZE s ON s.@TARGET_DOMAIN_ID_CONCEPT_ID = cu.@TARGET_DOMAIN_ID_CONCEPT_ID
206209
ORDER BY
207210
s.@TARGET_DOMAIN_ID_CONCEPT_ID,
@@ -227,7 +230,8 @@ select
227230
, STDEV(aers) aers_stdev
228231
, STDEV(aers_prr) aers_prr_stdev
229232
INTO #summary_stdev
230-
from #summary;
233+
FROM #summary
234+
WHERE #summary.in_universe = 1;
231235

232236
-- Compute the scaled varaiables and keep this in a temp table
233237
IF OBJECT_ID('tempdb..#summary_scaled', 'U') IS NOT NULL
@@ -265,7 +269,8 @@ select
265269
, CASE WHEN aers_stdev = 0 THEN 0 ELSE (aers / aers_stdev) END aers_scaled
266270
, CASE WHEN aers_prr_stdev = 0 THEN 0 ELSE (aers_prr / aers_prr_stdev) END aers_prr_scaled
267271
INTO #summary_scaled
268-
FROM #summary, #summary_stdev;
272+
FROM #summary, #summary_stdev
273+
WHERE #summary.in_universe = 1;
269274

270275
-- Apply the model
271276
IF OBJECT_ID('tempdb..#model_applied', 'U') IS NOT NULL

0 commit comments

Comments
 (0)