Skip to content

The Korean sentence order in Authorship description is incorrect. #2381

Open
@tandara0

Description

Expected behavior

Below picture is the sample of Authorship description in english.

created by ohdsi on 2024-02-08 8:46
image

In korean, the description must be as below.

ohdsi가 2024-02-08 8:46에 생성
image

Actual behavior

But, currently the description is very strange to korean since the sentence order is not proper.

만들어진 by ohdsi ~에 2024-02-08 8:46
image

Steps to reproduce behavior

You may change the language as below.
image

Solution

To solve this problem, I added createdEnd and modifiedEnd to the components.authorship entry in the i18n/messages_ko.json file.
I think this is the only method of choice because the order of sentences in Korean is different.
And In Atlas UI, the authorship.html must be changed to use the added createdEnd and modifiedEnd.

I already change both source WebAPI and Atlas, then test was done in my local environment.
I will commit the changes to both WebAPI and Atlas.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions