Skip to content

[DE] MediaPlayer: "weiter" triggers MediaNext instead of MediaUnpause#3655

Draft
hecktech27 wants to merge 1 commit into
OHF-Voice:mainfrom
hecktech27:hecktech_media_additions6
Draft

[DE] MediaPlayer: "weiter" triggers MediaNext instead of MediaUnpause#3655
hecktech27 wants to merge 1 commit into
OHF-Voice:mainfrom
hecktech27:hecktech_media_additions6

Conversation

@hecktech27

Copy link
Copy Markdown
Contributor

This PR moves weiter as a command from HassMediaUnpause to HassMediaNext.
In my opinion sentences like

  • Weiter
  • TV weiter
  • Wohnzimmer weiter

should trigger MediaNext(changed in this PR) while sentences like Musik weiter laufen lassen should trigger MediaUnpause(as they already do)

@andreasbrett andreasbrett left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree, for me "TV weiter" is conditional and should only play the next media item when the player is currently playing. When it is currently paused, "TV weiter" should unpause the player. At least that's my intent or expectation when saying "TV weiter".

That logic would need to be implemented upstream by @synesthesiam.

@mib1185

mib1185 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

I agree with @andreasbrett or at least would like to keep it as is for now, until we have the possibility for conditional intents.
I use it often in the flow of "ok nabu, pause" ... "ok nabu, weiter"

@mib1185 mib1185 marked this pull request as draft December 31, 2025 00:29
@hecktech27

Copy link
Copy Markdown
Contributor Author

while i do agree with you that this is conditional(i would love conditional sentence matching based on target device state... would open up a lot of possibilities) at least for me "weiter" is closer to "next title" than "resume playback" and i would expect it to behave like that. but maybe thats a me-thing ;)

regarding conditional sntence matching:
maybe something like

requires_state_match:
  state: paused

or

requires_state_match:
  state_not: paused

would be possible at some point in the future.

@mib1185

mib1185 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

"we" maybe could file a feature request for the conditional intents or place it on the discord channel 🤔 😬

About moving "weiter" from HassMediaUnpause to HassMediaNext, I still think we shouldn't do this, as it changes already existing behaviour and users might already be common with this (at least there are no feedbacks, which would complain about it) so this properly would need to be classified as a breaking change or better should be discussed with the community what they think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants