[DE] MediaPlayer: "weiter" triggers MediaNext instead of MediaUnpause#3655
[DE] MediaPlayer: "weiter" triggers MediaNext instead of MediaUnpause#3655hecktech27 wants to merge 1 commit into
Conversation
andreasbrett
left a comment
There was a problem hiding this comment.
I disagree, for me "TV weiter" is conditional and should only play the next media item when the player is currently playing. When it is currently paused, "TV weiter" should unpause the player. At least that's my intent or expectation when saying "TV weiter".
That logic would need to be implemented upstream by @synesthesiam.
|
I agree with @andreasbrett or at least would like to keep it as is for now, until we have the possibility for conditional intents. |
|
while i do agree with you that this is conditional(i would love conditional sentence matching based on target device state... would open up a lot of possibilities) at least for me "weiter" is closer to "next title" than "resume playback" and i would expect it to behave like that. but maybe thats a me-thing ;) regarding conditional sntence matching: or would be possible at some point in the future. |
|
"we" maybe could file a feature request for the conditional intents or place it on the discord channel 🤔 😬 About moving "weiter" from HassMediaUnpause to HassMediaNext, I still think we shouldn't do this, as it changes already existing behaviour and users might already be common with this (at least there are no feedbacks, which would complain about it) so this properly would need to be classified as a breaking change or better should be discussed with the community what they think about it. |
This PR moves
weiteras a command from HassMediaUnpause to HassMediaNext.In my opinion sentences like
should trigger MediaNext(changed in this PR) while sentences like
Musik weiter laufen lassenshould trigger MediaUnpause(as they already do)