Skip to content

[fr] Add HassListCompleteItem#3840

Merged
synesthesiam merged 5 commits into
OHF-Voice:mainfrom
jlpouffier:feat/fr-HassListCompleteItem
Jun 9, 2026
Merged

[fr] Add HassListCompleteItem#3840
synesthesiam merged 5 commits into
OHF-Voice:mainfrom
jlpouffier:feat/fr-HassListCompleteItem

Conversation

@jlpouffier

Copy link
Copy Markdown
Member

Summary

  • Adds French sentences for HassListCompleteItem in slot-combination format
  • Covers name_item combo (named todo list + item)
  • Adds French response: "{{ slots.item }} coché"

Combos covered

Combo Example
name_item "coche sortir les poubelles de la liste des tâches"

Test plan

  • python3 -m script.intentfest validate --language fr passes
  • Spot-check: "barre sortir les poubelles de ma liste des tâches" → HassListCompleteItem

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jlpouffier jlpouffier marked this pull request as ready for review April 29, 2026 08:16
…eteItem

# Conflicts:
#	sentences/fr/_common.yaml
@synesthesiam synesthesiam requested a review from piitaya as a code owner June 9, 2026 16:15
@synesthesiam

Copy link
Copy Markdown
Contributor

Resolved the conflict with main (the coche expansion rule already landed via #3838) and removed <supprime> from the sentences.

<supprime> ("delete") collided with #3841 (HassListRemoveItem), which is also todo-domain: "Supprime … de la liste …" was resolving to HassListCompleteItem instead of HassListRemoveItem, breaking test_todo_HassListRemoveItem. Completing an item is now triggered by <coche> (coche/cocher/valide/valider/marque/marquer) only. Full fr suite passes (315). Merging.

@synesthesiam synesthesiam merged commit e41f828 into OHF-Voice:main Jun 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants