feat(image-orientation-patient): add additional validation of the image orientation patient value before accepting it in the MetadataProvider #5567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/additional-validation-of-image-orientation-patient
|
| Run status |
|
| Run duration | 02m 25s |
| Commit |
|
| Committer | Ibrahim |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
37
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional validation to the ImageOrientationPatient value before accepting it, and it doesn't pass all conditions its rejected and the fallback is used.
Example file: clean_dicom.dcm.zip
This is an image with an invalid/illegal image orientation patient value [0,0,0,0,0,0], An all-zero orientation means both the row-direction and column-direction vectors are (0,0,0). Geometrically, this yields no defined image plane which leads to impossible display of the image. This PR adds a fallback incase of such scenarios so images can be displayed correctly.
Before / After: