fix: Segmentations disappearing #5669
Conversation
✅ Deploy Preview for ohif-dev canceled.
|
| "directory": "./platform/public" | ||
| }, | ||
| { | ||
| "packageName": "@icr/polyseg-wasm", |
There was a problem hiding this comment.
this is very strange. it was working before, and we didn't have this here at the time it was working. So i'm wondering what has changed that we need this here
There was a problem hiding this comment.
It wasn't failing before because it wasn't actually invoking the convert to labelmap code, it was just displaying the contour as is. If you know a specific date/branch that it was both loading successfully AND auto-converting to labelmap, please let me know when that got added/changed.
There was a problem hiding this comment.
Checked mid-april build - definitely was just loading rtstruct as contours at that point.
There was a problem hiding this comment.
It doesn't work as of October 3rd either - so I'm wondering when you think this could have been working.
There was a problem hiding this comment.
This is only needed for dev:fast running - somehow the full run is ok generally, whether I build it locally or it is the production build.
jbocce
left a comment
jbocce
left a comment
There was a problem hiding this comment.
See @sedghi's comment. Also, I think @aimee-ferreira should be listed as a reviewer to test this.
Viewers
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/segmentation-disappear
|
| Run status |
|
| Run duration | 02m 50s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
13
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
24
|
Passing
|
0
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
study-list/OHIFStudyList.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Study List > Desktop resolution > Displays several studies initially |
Test Replay
Screenshots
Video
|
|
measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed |
Test Replay
Screenshots
Video
|
|
measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed |
Test Replay
Screenshots
Video
|
|
measurement-tracking/OHIFCornerstoneHotkeys.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Cornerstone Hotkeys > checks if hotkeys "R" and "L" can rotate the image |
Test Replay
Screenshots
Video
|
|
measurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Study Browser > checks if series thumbnails are being displayed |
Test Replay
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.
Context
Going into 3d main view after adding a segmentation causes the segmentation to disappear from all windows.
There is a separate issue that the segmentation isn't listed in the right hand panel, but I'd like to get the basic exceptions fixed and then worry about the UI fix separately.
Changes & Results
List @icr/polyseg-wasm in the pluginConfig so that the library is available.
Testing
See the issue: #5651 for details.
Also, #5643 is addressed as far as the exceptions/ability to hydrate.
The issues with various viewports not getting correctly synced is a separate issue.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment