Skip to content

Conversation

@Devu-trenser
Copy link
Contributor

@Devu-trenser Devu-trenser commented Jan 9, 2026

Context

This MR fixes an issue in NUM content item handling where ContentSequence was assumed to always be present.

In DICOM SR (e.g. TID 300 / TID 1501), NUM items may represent purely numeric measurements without any spatial reference (SCOORD / SCOORD3D). Attempting to access ValueType unconditionally caused unnecessary warnings and could skip valid numeric measurements.

This change makes spatial processing conditional on the presence of ContentSequence, aligning the implementation with the DICOM SR specification.

Changes & Results

Guard access to ContentSequence before reading ValueType

Testing

This PR is related to dcmjs-org/dcmjs#460 and cornerstonejs/cornerstone3D#2430

Verified that SR files are loaded correctly.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Jan 9, 2026

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 02c39a9
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6964f7495e1e810008a59389
😎 Deploy Preview https://deploy-preview-5703--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant