fix: Handle optional ContentSequence for NUM content items #5703
+13
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This MR fixes an issue in NUM content item handling where ContentSequence was assumed to always be present.
In DICOM SR (e.g. TID 300 / TID 1501), NUM items may represent purely numeric measurements without any spatial reference (SCOORD / SCOORD3D). Attempting to access ValueType unconditionally caused unnecessary warnings and could skip valid numeric measurements.
This change makes spatial processing conditional on the presence of ContentSequence, aligning the implementation with the DICOM SR specification.
Changes & Results
Guard access to ContentSequence before reading ValueType
Testing
This PR is related to dcmjs-org/dcmjs#460 and cornerstonejs/cornerstone3D#2430
Verified that SR files are loaded correctly.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment