Skip to content

Conversation

@GhadeerAlbattarni
Copy link
Contributor

Context

Fixes #5634

When an SR series is viewed/opened for the second time (via double-click or drag-and-drop), it causes a crash with TypeError: getAllVolumeIds is not a function because the cine service assumes all viewports are volume viewports.

Changes

  • Added a guard in initCineService.ts to return early when getAllVolumeIds is not available.

Results

The viewer no longer crashes when you reopen the SR series

Before:
Reopening an SR series causes OHIF to crash with getAllVolumeIds is not a function.

Screenshot 2026-01-17 at 9 54 05 AM

After:
SR series can be reopened without causing any crash or errors.

Testing

  1. Open the study with StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7310.5101.860473186348887719777907797922
  2. Hydrate the SR series.
  3. Use the measurements panel to navigate between measurements.
  4. Attempt to view the SR series again
  5. Verify no crash happens

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: macOS 10.15.4
  • Node version: v22.12.0
  • Browser: Chrome 83.0.4103.116

@netlify
Copy link

netlify bot commented Jan 17, 2026

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 9c14c59
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/696bcdf22dc867000865fd2d
😎 Deploy Preview https://deploy-preview-5724--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@GhadeerAlbattarni GhadeerAlbattarni changed the title fix(cine): prevent crash on second view/hydration of SR series #5634 fix(cine): prevent crash on second view/hydration of SR series Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] OHIF crashes on second view/hydration of SR series

1 participant