Skip to content

[WIP] Update to use beta 5.0 of CS3D#5904

Open
wayfarer3130 wants to merge 7 commits intomasterfrom
feat/use-beta-5.0-cs3d
Open

[WIP] Update to use beta 5.0 of CS3D#5904
wayfarer3130 wants to merge 7 commits intomasterfrom
feat/use-beta-5.0-cs3d

Conversation

@wayfarer3130
Copy link
Copy Markdown
Contributor

@wayfarer3130 wayfarer3130 commented Mar 17, 2026

Context

CS3D_REF: feat/metadata-module

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Greptile Summary

This PR renames the single test in tests/3DFourUp.spec.ts from "should render 3D four up correctly." to "should render 3D four up correctly with load check." and reformats the test function signature for readability. No logic, assertions, or test steps were changed.

Key observations:

  • PR title / content mismatch: The PR title is "[WIP] Update to use beta 5.0 of CS3D", which implies a dependency upgrade and potentially breaking API or rendering changes across the codebase. However, the only change present in this diff is a test rename. The actual dependency update, any API migration, and corresponding baseline screenshot refreshes appear to be absent. This may be expected for a [WIP] branch, but it means the PR is not yet reviewable in its current state.
  • Empty PR description: None of the checklist sections (Context, Changes & Results, Testing, Tested Environment) have been filled in, making it difficult to understand intent or how to validate the change.
  • Screenshot baseline: screenShotPaths.threeDFourUp.threeDFourUpDisplayedCorrectly references an explicit filename (threeDFourUpDisplayedCorrectly.png), so the test rename itself won't invalidate existing baselines. However, if CS3D 5.0 beta changes rendering output, those baselines will very likely need to be regenerated.
  • The waitForVolumeLoad() call was already present before this PR — the rename correctly documents pre-existing behavior.

Confidence Score: 3/5

  • The isolated test rename is safe, but the PR title implies a much larger Cornerstone3D 5.0 beta migration that is entirely absent from the diff.
  • The single code change (test rename + formatting) is trivially safe and cannot break anything. The score is held at 3 rather than 5 because the PR is explicitly marked [WIP], the description is empty, and the stated goal ("Update to use beta 5.0 of CS3D") is not reflected in the diff — indicating that significant, potentially breaking changes are still pending and should be reviewed before merge.
  • No files require special attention for the current diff, but once the CS3D 5.0 dependency update lands the baseline screenshots (e.g., threeDFourUpDisplayedCorrectly.png) and any migrated API call-sites will need close review.

Important Files Changed

Filename Overview
tests/3DFourUp.spec.ts Test description renamed from "should render 3D four up correctly." to "should render 3D four up correctly with load check." and function signature reformatted; no logic changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A([test.beforeEach]) --> B[visitStudy\nstudyInstanceUID, viewer mode, 2000ms]
    B --> C[test: should render 3D four up correctly\nwith load check]
    C --> D[mainToolbarPageObject.layoutSelection\n.threeDFourUp.click]
    D --> E[attemptAction: reduce3DViewportSize\n10 attempts, 100ms delay]
    E --> F[mainToolbarPageObject.waitForVolumeLoad]
    F --> G[checkForScreenshot\npage, page, threeDFourUpDisplayedCorrectly.png]
    G --> H{Screenshot\nmatches?}
    H -- Yes --> I([Test Passes])
    H -- No, retry up to 10x --> G
    H -- All retries exhausted --> J([Test Fails])
Loading

Last reviewed commit: b6fc372

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 17, 2026

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 718f9ff
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/69cad1a1ce83800008581420

@wayfarer3130 wayfarer3130 added the ohif-integration Causes a CS3D/OHIF integraiton build to be run label Mar 17, 2026
@cypress
Copy link
Copy Markdown

cypress bot commented Mar 17, 2026

Viewers    Run #6135

Run Properties:  status check passed Passed #6135  •  git commit 718f9ff2d9: Linking for cs3d metadata
Project Viewers
Branch Review feat/use-beta-5.0-cs3d
Run status status check passed Passed #6135
Run duration 02m 17s
Commit git commit 718f9ff2d9: Linking for cs3d metadata
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 37
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ohif-integration Causes a CS3D/OHIF integraiton build to be run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant