Skip to content

fix: remove thresholdRange label in double-range tool settings #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GhadeerAlbattarni wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −21
Open

fix: remove thresholdRange label in double-range tool settings #5931

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82125ce
fix: remove thresholdRange label in double-range tool settings
GhadeerAlbattarni Mar 30, 2026
d704390
Merge remote-tracking branch 'upstream/master' into fix/5894-threshol…
GhadeerAlbattarni Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 10 additions & 21 deletions platform/ui-next/src/components/OHIFToolSettings/ToolSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,25 +118,16 @@ const renderRadioSetting = option => {

function renderDoubleRangeSetting(option) {
return (
<div
className="flex items-center"
<RowDoubleRange
key={option.id}
>
<div className="w-1/3 text-[13px]">
{renderLabelWithTooltip(option.name, option.tooltip)}
</div>
<div className="w-2/3">
<RowDoubleRange
values={option.value}
onChange={option.onChange}
minValue={option.min}
maxValue={option.max}
step={option.step}
showLabel={false}
tooltip={option.tooltip}
/>
</div>
</div>
values={option.value}
onChange={option.onChange}
minValue={option.min}
maxValue={option.max}
step={option.step}
showLabel={false}
tooltip={option.tooltip}
/>
);
}

Expand Down Expand Up @@ -225,9 +216,7 @@ const renderSelectSetting = option => {
className="flex items-center"
key={option.id}
>
<div className="w-1/3 text-[13px]">
{renderLabelWithTooltip(option.name, option.tooltip)}
</div>
<div className="w-1/3 text-[13px]">{renderLabelWithTooltip(option.name, option.tooltip)}</div>
<div className="w-2/3">
<Select
onValueChange={value => option.onChange?.(value)}
Expand Down
Loading