github-ci: consolidate new authors check into a single workflow - #15571
Closed
jasonish wants to merge 1 commit into
Closed
github-ci: consolidate new authors check into a single workflow#15571jasonish wants to merge 1 commit into
jasonish wants to merge 1 commit into
Conversation
Replace the two-workflow pattern (authors.yml + authors-done.yml) with a single pull_request_target workflow. I'm not sure this was possible when this job was originally created, but apparently it is now.
Member
Author
|
This is hard to test, as it has to exist on main. I tested on my own repo and the message can be seen here: jasonish#328 But to really test, someone needs to create a pull request against my repo, where the source repo is not my repo as well. And use a new ID that has not been seen before. |
|
Information: QA skipped due to no C or rust code changed detected. Set to force a run. Pipeline = code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15571 +/- ##
==========================================
- Coverage 82.86% 82.85% -0.01%
==========================================
Files 999 999
Lines 272627 272627
==========================================
- Hits 225904 225884 -20
- Misses 46723 46743 +20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Jun 9, 2026
This was referenced Jun 10, 2026
Closed
Closed
Member
|
replaced by #15598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the two-workflow pattern (authors.yml + authors-done.yml) with a
single pull_request_target workflow.
I'm not sure this was possible when this job was originally created, but
apparently it is now.
Why: We recently saw the new authors check run and find new authors, but the second workflow to add the comment didn't run. And this is just simpler.