Dcerpc flags/v1 - #15949
Draft
inashivb wants to merge 2 commits into
Draft
Conversation
To allow matches with dcerpc.flags keyword later on. DCERPC/TCP exposes a u8 as PFC flags in its header however, DCERPC/UDP stores two sets of flags flags1 and flags2 in its header. Hence, the field is kept u16 to accommodate for both.
This is a u16 keyword that matches on flags field derived from the header of a DCERPC packet per transaction per direction. Feature 8734
inashivb
commented
Jul 29, 2026
| _de: *mut DetectEngineThreadCtx, _f: *mut crate::flow::Flow, flags: u8, _state: *mut c_void, | ||
| tx: *mut c_void, _sig: *const Signature, ctx: *const SigMatchCtx, | ||
| ) -> c_int { | ||
| let tx = cast_pointer!(tx, DCERPCTransaction); |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15949 +/- ##
==========================================
- Coverage 83.03% 82.97% -0.06%
==========================================
Files 1003 1003
Lines 276582 276651 +69
==========================================
- Hits 229647 229553 -94
- Misses 46935 47098 +163
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 32733 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8734
SV_BRANCH=OISF/suricata-verify#3254