-
Notifications
You must be signed in to change notification settings - Fork 1.8k
firewall: add default-policy to policy config v3 #15950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukashino
wants to merge
4
commits into
OISF:main
Choose a base branch
from
lukashino:feat/8712-fw-default-policy-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5391c44
detect/firewall: address HTTP/1 policies as http1
2b17b7e
detect/firewall: group policies under packet and app nodes
b5ced77
detect/firewall: add default-policy to policy config
04309fb
detect/firewall: validate action scope against the hook class
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,7 +62,7 @@ Application layer tables | |
| ~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| If applayer is available, rules from the following tables apply. The tables for the | ||
| application layer are per app layer protocol and per protocol state. e.g. ``http:request_line``. | ||
| application layer are per app layer protocol and per protocol state. e.g. ``http1:request_line``. | ||
|
|
||
|
|
||
| .. table:: | ||
|
|
@@ -349,29 +349,51 @@ The example below accepts ARP again, using this mechanism. | |
| Default policies | ||
| ================ | ||
|
|
||
| Each hook has a default policy. By default ``packet:filter`` enforces a ``drop:packet`` policy and the | ||
| ``app:filter`` hooks applies ``drop:flow``. | ||
| Each hook has a default policy applied to traffic that no firewall rule handled. | ||
| By default ``packet.filter`` enforces ``drop:packet``, ``packet.pre-flow`` and | ||
| ``packet.pre-stream`` enforce ``accept:hook``, and every ``app`` hook enforces | ||
| ``drop:flow``. | ||
|
|
||
| The policies can be configured in ``firewall`` block in the config. | ||
|
|
||
| Example for ``packet:filter``, to use reject instead of drop:: | ||
| Defaults are configured in the ``firewall.policies`` block. A ``default-policy`` | ||
| may be given at several levels; for any hook the most specific present setting | ||
| wins:: | ||
|
|
||
| firewall: | ||
| policies: | ||
| packet-filter: [ "reject:packet" ] | ||
|
|
||
|
|
||
| Example for DNS:: | ||
| default-policy: ["accept:hook"] # global fallback (all hooks) | ||
| packet: | ||
| default-policy: ["drop:packet"] # fallback for packet hooks | ||
| filter: ["drop:packet"] | ||
| pre-flow: ["accept:hook"] | ||
| pre-stream: ["accept:hook"] | ||
| app: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe nitty, but as far as naming goes, I prefer
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the idea is to make sure it is about the app layer, so I prefer app here |
||
| default-policy: ["drop:flow"] # fallback for all app hooks | ||
| dns: | ||
| default-policy: ["drop:flow"] # fallback for dns hooks | ||
| request-started: ["accept:hook"] | ||
| request-complete: ["drop:flow", "alert"] | ||
| response-started: ["accept:tx"] | ||
|
|
||
| Protocols whose hooks are grouped into sub states, such as HTTP/2, take an extra | ||
| level for the sub state name:: | ||
|
|
||
| firewall: | ||
| policies: | ||
| dns: | ||
| request-started: ["accept:hook"] | ||
|
|
||
| # Drop and alert on all DNS requests that are not allowed in | ||
| # firewall.rules. | ||
| request-complete: ["drop:flow", "alert"] | ||
|
|
||
| # Accept all responses. | ||
| response-started: ["accept:tx"] | ||
|
|
||
| app: | ||
| http2: | ||
| default-policy: ["drop:flow"] # fallback for all http2 hooks | ||
| stream: | ||
| default-policy: ["drop:flow"] # fallback for http2 stream hooks | ||
| request-started: ["accept:hook"] | ||
| global: | ||
| request-started: ["accept:hook"] | ||
|
|
||
| Precedence: | ||
|
|
||
| * packet hook: ``packet.<hook>`` > ``packet.default-policy`` > | ||
| ``policies.default-policy`` > built-in (``drop:packet`` or ``accept:hook``) | ||
| * app hook: ``app.<proto>.<hook>`` > ``app.<proto>.default-policy`` > | ||
| ``app.default-policy`` > ``policies.default-policy`` > built-in (``drop:flow``) | ||
| * app hook in a sub state: ``app.<proto>.<sub state>.<hook>`` > | ||
| ``app.<proto>.<sub state>.default-policy`` > ``app.<proto>.default-policy`` > | ||
| ``app.default-policy`` > ``policies.default-policy`` > built-in (``drop:flow``) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be confirmed, but if we already have stuff backported where
httpis an alias tohttp1, should we keep it that way? (or do we change in 9, and document?)