Skip to content

Feat migrate core to new oscd UI components #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

stee-re
Copy link
Contributor

@stee-re stee-re commented Jun 2, 2025

No description provided.

@stee-re stee-re requested a review from ca-d June 2, 2025 13:08
@stee-re stee-re force-pushed the feat_migrate-core-to-new-oscd-ui-components branch 2 times, most recently from 1cd6ee4 to 27bb7cc Compare June 2, 2025 14:01
Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work, the substantial changes you made are looking great and working fine on my machine! Also, the improvements to naming and CI that you made are much appreciated, thanks for putting in the extra effort on those fronts.

There are three very minor things I've noticed about the incidental changes included in this pull request:

  • husky pre-commit hooks don't seem to be automatically registered any more on my machine after the bump from version 4 to version 9. Is this still working for you? If not, do we maybe need to add something to our pre-install script to register them? Also, what do you think about adding commitlint to our pre-commit hooks?
  • Some of the visual changes in the "update screenshots" commit seem unintentional to me at first glance, like a different tab being selected (maybe 1-based vs 0-based indexing?), tab selection looking different, or the app bar seeming slightly taller than before. Have you checked the visual diffs at the end, and if so, are these changes intended?
  • I don't really see the need for separating the tests for editing/plugging/oscd-shell any more, since they haven't been separately testable mixins in a while. Do you think the same way, and if so, would you consider consolidating all unit tests into a single oscd-shell.spec.ts?

@stee-re stee-re force-pushed the feat_migrate-core-to-new-oscd-ui-components branch from 4898ec4 to 2ebcb5f Compare June 11, 2025 14:28
@stee-re
Copy link
Contributor Author

stee-re commented Jun 11, 2025

@ca-d thanks for your feedback.

  • Husky is back working and commitlint has also been added.
  • The visual regression differences were down to timing issues which only affected the tests.
  • With regards to merging the test files, I'm concerned about the size of our files already, I'm not comfortable making them even bigger.

Other smaller changes also thrown in:

  • I updated our test related dependencies to what @open-wc are recommending.
  • The filename for the zipped release artifact was corrected
  • Added status badges to our README.md
  • Updated README.md references to @omicronenergy/oscd-shell
  • Figured out that the meaning of life is actually 42

Copy link
Contributor

@ca-d ca-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

Also, thanks for figuring out that meaning question.

@stee-re stee-re force-pushed the feat_migrate-core-to-new-oscd-ui-components branch from 6009ce4 to 94211dc Compare June 11, 2025 15:45
@stee-re stee-re merged commit aba68bd into OMICRONEnergyOSS:main Jun 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants