Document editor screen jumping full fix #4850
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 task
toad
force-pushed
the
document-editor-screen-jumping-full-fix
branch
4 times, most recently
from
89a1d77 to
e4d61d0
Compare
toad
force-pushed
the
document-editor-screen-jumping-full-fix
branch
from
e4d61d0 to
73d1f0e
Compare
amovsisyan's patch looks for an anchor to save the position relative to. Which works fine as long as there are anchors on every page. Unfortunately with tables this often is not the case. If GetDocumentPositionByXY() returns an anchor on a previous, invisible page, try moving down the current page 10 pixels at a time until we find an anchor on this page. This is similar to what the code above does. If that does not work either, we need to reference an anchor on a previous page. Use ConvertCoordsToAnotherPage() to do this correctly.
When we get an update, we set ViewPosition. This will in theory be used to position the next rendered frame via CheckTargetUpdate(). However it can be some time before CheckViewPosition() actually gets as far as scrolling to the saved position, because of recalculations. So we need to check whether there has been any scrolling since we saved ViewPosition. This adds an additional bit of state, savedTopOffset, which is the top cursor position of the top page at the time of generating ViewPosition. Probably it should be on one of the State/ViewPosition Anchor values.
Store it in the correct state object rather than as a property directly on the Document. This is more consistent and should avoid any bugs with e.g. state saving on undo.
toad
force-pushed
the
document-editor-screen-jumping-full-fix
branch
from
73d1f0e to
4626c0c
Compare
|
Any news on whether this PR will be accepted and bundled into the next release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the jumping bug for me (bug 3054: ONLYOFFICE/DocumentServer#3054 ) and is an extension on #4848 .
Note that this includes the patch from @amovsisyan. You will need them to sign the CLA as well as me. Unfortunately they changed the email address they commit with.