cmake: raise minimum required to 3.5#795
Merged
Merged
Conversation
jforissier
reviewed
Apr 30, 2025
Contributor
jforissier
left a comment
jforissier
left a comment
There was a problem hiding this comment.
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Contributor
|
s/mimimum/minimum/ in the subject, though 😉 |
Contributor
|
|
Contributor
|
|
sudeep-holla
force-pushed
the
cmake_4.0_fix
branch
from
fba7436 to
5e6ea1a
Compare
CMake 4.0 was released [1] which dropped compatibility with versions older than 3.5 and causes cmake_minimum_required(3.4) to fail. Bump the minimum required version to 3.5, which was released 9 years ago. [1] https://www.kitware.com/cmake-4-0-0-available-for-download/ With v4.0.0 the following build error is observed: | CMake Error at CMakeLists.txt:1 (cmake_minimum_required): | Compatibility with CMake < 3.5 has been removed from CMake. | | Update the VERSION argument <min> value. Or, use the <min>...<max> syntax | to tell CMake that the project requires at least <min> but has been updated | to work with policies introduced by <max> or earlier. | | Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
sudeep-holla
force-pushed
the
cmake_4.0_fix
branch
from
5e6ea1a to
3e7f239
Compare
sudeep-holla
changed the title
Contributor
|
OP-TEE/manifest#324 should address the CI failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake 4.0 was released [1] which dropped compatibility with versions older than 3.5 and causes cmake_minimum_required(3.4) to fail. Bump the minimum required version to 3.5, which was released 9 years ago.
[1] https://www.kitware.com/cmake-4-0-0-available-for-download/
With v4.0.0 the following build error is observed:
| CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
| Compatibility with CMake < 3.5 has been removed from CMake.
|
| Update the VERSION argument value. Or, use the ... syntax
| to tell CMake that the project requires at least but has been updated
| to work with policies introduced by or earlier.
|
| Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.