build: make, cmake: add -Werror based on CFG_WERROR#797
Merged
Conversation
|
Thanks! This is useful in distro integration when toolchains are updated etc. |
Contributor
|
I think it should be disabled by default. That's what we have in optee_os. |
Contributor
Author
Hmmm yes let's make it disabled by default. |
Contributor
Author
|
Update |
Contributor
|
|
etienne-lms
reviewed
May 7, 2025
Contributor
etienne-lms
left a comment
etienne-lms
left a comment
There was a problem hiding this comment.
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
Update the build files that currently set -Werror unconditionally to use set it based on the value of CFG_WERROR instead (disabled by default). Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the build files that currently set -Werror unconditionally to use set it based on the value of CFG_WERROR instead. CFG_WERROR is set to y by default, but may be unset (or set to n) from the build command line or the environment.