xtest: pkcs11: add tests for indestructible token objects by sahesaha · Pull Request #803 · OP-TEE/optee_test

sahesaha · 2025-11-03T14:10:42Z

Add test cases that validate CKA_INDESTRUCTIBLE behavior:

A session object with CKA_INDESTRUCTIBLE=CK_TRUE and CKA_TOKEN=CK_FALSE is rejected with CKR_TEMPLATE_INCONSISTENT.
Token objects marked CKA_INDESTRUCTIBLE cannot be destroyed.

Tested on: SM7325 SoC

Reviewed-by: Neeraj Soni neersoni@qti.qualcomm.com
Signed-off-by: Saheli Saha sahesaha@qti.qualcomm.com

Add test cases that validate CKA_INDESTRUCTIBLE behavior: - A session object with CKA_INDESTRUCTIBLE=CK_TRUE and CKA_TOKEN=CK_FALSE is rejected with CKR_TEMPLATE_INCONSISTENT. - Token objects marked CKA_INDESTRUCTIBLE cannot be destroyed. Tested on: SM7325 SoC Reviewed-by: Neeraj Soni <neersoni@qti.qualcomm.com> Signed-off-by: Saheli Saha <sahesaha@qti.qualcomm.com>

github-actions · 2025-12-04T02:19:49Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

sahesaha · 2025-12-08T06:29:59Z

Commenting to keep alive.

github-actions · 2026-01-08T02:27:46Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

etienne-lms

Thanks for the test sequences related to indestructible objects.
The issue is that once such objects are created, they're never destroyed and the pkcs11 TA persistent database would continuously grow. That said, it's nice for testing purpose only when it's easy to wipe the persistent database. I would suggest to add a config switch (e.g. CFG_PKCS11_TA_TEST_INDESTRUCTIBLE_OBJECT_ATTR=y|n) so we can leverage these tests on Qemu (emulated persistent secure storage) and maybe other platforms where one can deal with such forced database destruction.

etienne-lms · 2026-01-08T15:35:51Z

+	rv = C_CreateObject(session, cktest_destructible_token,
+			    ARRAY_SIZE(cktest_destructible_token),
+			    &obj_hdl2);
+	if (!ADBG_EXPECT_CK_OK(c, rv))
+		goto end;


Remove these lines? the destrcutible object is create right below, after C_DestroyObject(session, obj_hdl) call.

etienne-lms · 2026-01-08T15:38:36Z

+		goto end;
+
+	/* Indestructible object is accessible */
+	rv = C_GetObjectSize(session, obj_hdl, &obj_size);


Once the sessions are closed (even if token is NOT re-initialized), the object handles should no more be valid. You should still be able to find the object, do not access its handle.

etienne-lms · 2026-01-08T15:40:11Z

+/*
+ * This test involves creating multiple token keys with both
+ * indestructible and destructible objects, and checking
+ * the uniqueness of key handles.


Objects being destructible or not, handles of created objects are always different. I don't think this test is useful.

etienne-lms · 2026-01-08T15:40:38Z

+/*
+ * Creating object with incorrect template
+ * (CKA_TOKEN is false but CKA_INDESTRUCTIBLE is true)
+ */


Could you fix the indentation?

etienne-lms · 2026-01-08T15:44:21Z

+	if (!ADBG_EXPECT_CK_RESULT(c, CKR_TEMPLATE_INCONSISTENT, rv))
+		goto end;
+
+	rv = C_GetObjectSize(session, obj_hdl, &obj_size);


It is a programming error to use obj_hdl when previous call to C_CreateObject() failed. The PKCS#11 API does not say the generated object handle needs to be set the CK_INVALID_ID or whatever when such C_CreateObject()/C_CopyOject()/C_DeriveKey()/... fail.

etienne-lms · 2026-01-08T15:46:53Z

+		goto end;
+
+	/* Indestructible object is accessible */
+	rv = C_GetObjectSize(session, obj_hdl, &obj_size2);


You should search the object first (use C_FindObjects*() functions), not reuse obj_hdl that is bound to a session.
(I need to verify this assertion).

etienne-lms · 2026-01-08T15:48:04Z

 	{ CKA_CLASS, &(CK_OBJECT_CLASS){CKO_SECRET_KEY},
 						sizeof(CK_OBJECT_CLASS) },
-	{ CKA_KEY_TYPE, &(CK_KEY_TYPE){CKK_AES}, sizeof(CK_KEY_TYPE) },
+	{ CKA_KEY_TYPE, &(CK_KEY_TYPE) { CKK_AES }, sizeof(CK_KEY_TYPE) },


I'd suggest to discard this change.
(or change also all other equivalent occurrences, preferably in a dedicated commit)

Hi @etienne-lms, this was shown as an error when I ran the checkpatch for this PR. hence fixed it.

sahesaha · 2026-02-11T08:34:59Z

@etienne-lms , could you suggest where and how to introduce the control flag to control the tests which I introduced for this feature?

github-actions · 2026-03-14T03:07:07Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

sahesaha · 2026-03-19T10:05:49Z

@jenswi-linaro @etienne-lms, could you please help restore the PR? Review is pending for this.

github-actions · 2026-04-19T03:50:39Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

sahesaha · 2026-04-24T05:08:40Z

@jenswi-linaro @etienne-lms, could you please help restore the PR and review it?

github-actions · 2026-05-25T04:53:13Z

This pull request has been marked as a stale pull request because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment, otherwise this pull request will automatically be closed in 5 days. Note that you can always re-open a closed pull request at any time.

sahesaha · 2026-05-25T05:42:04Z

Commenting to keep alive.

github-actions Bot added the Stale label Dec 4, 2025

jenswikl removed the Stale label Dec 8, 2025

github-actions Bot added the Stale label Jan 8, 2026

jenswikl removed the Stale label Jan 8, 2026

etienne-lms reviewed Jan 8, 2026

View reviewed changes

etienne-lms mentioned this pull request Jan 9, 2026

Added Indestructible token objects attributes/keys feature. OP-TEE/optee_os#7581

Open

github-actions Bot added the Stale label Mar 14, 2026

github-actions Bot closed this Mar 19, 2026

jenswikl reopened this Mar 19, 2026

github-actions Bot removed the Stale label Mar 20, 2026

github-actions Bot added the Stale label Apr 19, 2026

github-actions Bot closed this Apr 24, 2026

jenswikl reopened this Apr 24, 2026

jenswikl removed the Stale label Apr 24, 2026

github-actions Bot added the Stale label May 25, 2026

github-actions Bot removed the Stale label May 26, 2026

Conversation

sahesaha commented Nov 3, 2025

Uh oh!

github-actions Bot commented Dec 4, 2025

Uh oh!

sahesaha commented Dec 8, 2025

Uh oh!

github-actions Bot commented Jan 8, 2026

Uh oh!

etienne-lms left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sahesaha commented Feb 11, 2026

Uh oh!

github-actions Bot commented Mar 14, 2026

Uh oh!

sahesaha commented Mar 19, 2026

Uh oh!

github-actions Bot commented Apr 19, 2026

Uh oh!

sahesaha commented Apr 24, 2026

Uh oh!

github-actions Bot commented May 25, 2026

Uh oh!

sahesaha commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

etienne-lms left a comment •

edited

Loading