pkcs11: fix undefined behavior in attribute initialization (compound literals)#821
Open
sahesaha wants to merge 1 commit into
Open
pkcs11: fix undefined behavior in attribute initialization (compound literals)#821sahesaha wants to merge 1 commit into
sahesaha wants to merge 1 commit into
Conversation
Author
|
Hi @etienne-lms , could you review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Incorrect attribute values are observed in test_create_destroy_session_objects,
CKA_TOKEN = 0xe0 (expected CK_FALSE / 0)
The issue appears with default toolchain optimizations, even though no explicit -O2 is set. It disappears when forcing -O0, indicating optimization-dependent undefined behavior.
Root cause
Attributes are initialized using compound literals, e.g.:
C&(CK_BBOOL){CK_FALSE}
These create temporary objects whose addresses are stored and reused.
Their lifetime and storage are not guaranteed, and under optimization the compiler may reuse or overlap them, leading to invalid values.
Why not fix via -O0
Disabling optimization is not a valid solution:
Hides undefined behavior instead of fixing it
Not portable across compilers/toolchains
Impacts performance in security-sensitive code
Fix
Replace compound literals with static variables having stable storage:
e.g. static const CK_BBOOL ck_false = CK_FALSE;