feat: Add per-output enable/disable hotkeys#131
Merged
Conversation
Merged
hanatyan128
force-pushed
the
feat-individual-output-start-stop-hotkeys
branch
from
April 5, 2026 15:26
a0d7883 to
e40a416
Compare
… recording, and replay buffer control Register OBS hotkeys to individually enable/disable each output type: - Enable/Disable All Streaming (independent hotkeys) - Enable/Disable Streaming Service 1-8 (paired hotkeys per slot) - Enable/Disable Recording (paired hotkey) - Enable/Disable Replay Buffer (paired hotkey) Hotkey callbacks set the userEnabled intent flags and call the corresponding *Individual() methods. Per-slot streaming callbacks resolve the slot index by matching obs_hotkey_pair_id against the stored ID array. Also refactor existing hotkey callbacks to their respective files: streaming → plugin-streaming.cpp, recording → plugin-stream-recording.cpp, replay buffer → plugin-replay-buffer.cpp. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…fixes - Emit outputUserEnabledChanged signal from setters when value changes, connected to status dock for immediate checkbox sync on hotkey press - Fix hotkey pair toggle logic: return false when already in desired state so OBS correctly alternates enable/disable callbacks - Move setRecordingUserEnabled/setReplayBufferUserEnabled to cpp files - Add serviceCount check inside isStreamingEnabled to prevent stale slots - Register hotkeys conditionally based on enabled output types - Translate hotkey locale strings for all supported languages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…, fix thread safety - Extract unregisterAllHotkeys() helper to eliminate duplicate hotkey unregistration code in registerHotkey() and removeCallback() - Add obs_filter_get_parent() null check in registerHotkey() - Initialize togglePauseRecordingHotkeyPairId and addChapterToRecordingHotkeyId in constructor initializer list to avoid undefined behavior - Use Qt::QueuedConnection for outputUserEnabledChanged signal connection to ensure UI updates run on the UI thread when emitted from OBS core thread - Remove trailing blank lines before closing braces in streaming hotkey functions - Document OBS hotkey persistence mechanism (name-string-based keybinding restoration) in registerHotkey() comments Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hanatyan128
force-pushed
the
feat-individual-output-start-stop-hotkeys
branch
from
April 5, 2026 15:50
e40a416 to
aefaa6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outputUserEnabledChangedsignal for immediate status dock checkbox sync on hotkey pressunregisterAllHotkeys()helper extraction,obs_filter_get_parent()null check,Qt::QueuedConnectionthread safety fixChanges
New hotkeys
Code quality improvements
unregisterAllHotkeys()helper method (deduplicateregisterHotkey()/removeCallback())obs_filter_get_parent()null check inregisterHotkey()Qt::QueuedConnectionforoutputUserEnabledChangedsignal connection (cross-thread UI safety)Test plan
🤖 Generated with Claude Code