fix: Make Branch Output batch hotkeys work when the status dock is hidden#149
Open
hanatyan128 wants to merge 2 commits into
Open
fix: Make Branch Output batch hotkeys work when the status dock is hidden#149hanatyan128 wants to merge 2 commits into
hanatyan128 wants to merge 2 commits into
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #148. The global "Add chapter to all branch outputs" hotkey (and the other
*Allbatch hotkeys) silently did nothing for Branch Output while the same key keptworking for vanilla OBS recording.
Root cause
BranchOutputStatusDock::addChapterToRecordingAll()and its siblings gated eachfilter on
row->status->isAddChapterToRecordingButtonShow(). That value is thedock button's visibility, refreshed only by the dock's 2-second timer, which runs
only while the dock widget is visible (
showEvent/hideEvent, and theconstructor's
if (isVisible())). The button's initial state is invisible. So whenthe status dock is hidden/closed, the visibility flag is never updated and every
batch hotkey skips all filters — even though recording is active and the per-filter
action would succeed. The vanilla OBS chapter marker is an independent path and is
unaffected, matching the attached logs in the issue (only
adv_file_outputreceiveschapters before the workaround; all outputs receive them after).
Changes
splitRecordingAll,pauseRecordingAll,unpauseRecordingAll,addChapterToRecordingAll,saveReplayBufferAll. Each filter action already self-guards underoutputMutexand re-checks real output state, so unconditional per-row dispatch (filtered only
by row output type) is correct and dock-visibility independent.
addChapterToRecordingEnabledin theBranchOutputFilterconstructor.It was the only recording-context flag left uninitialized, allowing an
indeterminate read before the first recording start.
Verification
-Wreorder) and thecomment-discipline Info finding were addressed in this branch.
Manual testing recommended: with the Branch Output status dock hidden, start
recording (Interlock Recording) and confirm the global chapter / split / pause /
replay-buffer hotkeys act on all active Branch Output filters.
🤖 Generated with Claude Code