Patch 1.0.6#93
Merged
hanatyan128 merged 9 commits intoSep 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses critical stability issues and memory leaks in the Branch Output plugin, specifically targeting crashes on Mac/Linux systems during stream disconnects/reconnects and fixing streams stuck in perpetual reconnecting states.
- Implements a new signal-based reconnection mechanism to replace timeout-based connection handling
- Fixes memory leaks by properly cleaning up signals, hotkeys, and source callbacks
- Improves stream state management by tracking output starting/stopping states more accurately
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/plugin-main.hpp | Updates streaming context structure to use signal-based state tracking instead of timeout mechanisms |
| src/plugin-main.cpp | Implements signal handlers for output lifecycle, fixes memory leaks, and improves reconnection logic |
| src/audio/audio-capture.cpp | Adds null check to prevent crashes when removing audio capture callbacks |
| buildspec.json | Updates version number to 1.0.6 |
Comments suppressed due to low confidence (1)
src/plugin-main.cpp:1
- Potential null pointer dereference. The
sourcevariable could be null after the conditional check above, butobs_source_get_name(source)is called unconditionally in the log statement.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was
linked to
issues
Sep 29, 2025
hanatyan128
deleted the
fix-crash-on-connection-failure-for-mac-linux
branch
February 28, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes