Skip to content

Patch 1.0.6#93

Merged
hanatyan128 merged 9 commits into
masterfrom
fix-crash-on-connection-failure-for-mac-linux
Sep 30, 2025
Merged

Patch 1.0.6#93
hanatyan128 merged 9 commits into
masterfrom
fix-crash-on-connection-failure-for-mac-linux

Conversation

@hanatyan128

@hanatyan128 hanatyan128 commented Sep 27, 2025

Copy link
Copy Markdown
Member

Changes

  • Fix: On Mac/Linux, OBS Studio crashes when a stream disconnects or reconnects. Crash on Mac/Linux on SRT failure #92
  • Fix: A bug where the stream could not be deactivated when it was perpetually stuck in a “reconnecting” state.
  • Fix: Potential memory leaks.
  • Improve: New reconnection mechanism utilizing the output signals.
  • Fix prevous added fragmented mp4/mov support didn't work

@hanatyan128 hanatyan128 added this to the 1.0.6 milestone Sep 27, 2025
@hanatyan128 hanatyan128 self-assigned this Sep 27, 2025
@hanatyan128 hanatyan128 linked an issue Sep 27, 2025 that may be closed by this pull request
@hanatyan128
hanatyan128 requested a review from Copilot September 28, 2025 06:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses critical stability issues and memory leaks in the Branch Output plugin, specifically targeting crashes on Mac/Linux systems during stream disconnects/reconnects and fixing streams stuck in perpetual reconnecting states.

  • Implements a new signal-based reconnection mechanism to replace timeout-based connection handling
  • Fixes memory leaks by properly cleaning up signals, hotkeys, and source callbacks
  • Improves stream state management by tracking output starting/stopping states more accurately

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/plugin-main.hpp Updates streaming context structure to use signal-based state tracking instead of timeout mechanisms
src/plugin-main.cpp Implements signal handlers for output lifecycle, fixes memory leaks, and improves reconnection logic
src/audio/audio-capture.cpp Adds null check to prevent crashes when removing audio capture callbacks
buildspec.json Updates version number to 1.0.6
Comments suppressed due to low confidence (1)

src/plugin-main.cpp:1

  • Potential null pointer dereference. The source variable could be null after the conditional check above, but obs_source_get_name(source) is called unconditionally in the log statement.
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hanatyan128
hanatyan128 merged commit 2a80183 into master Sep 30, 2025
6 checks passed
@hanatyan128
hanatyan128 deleted the fix-crash-on-connection-failure-for-mac-linux branch February 28, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on Mac/Linux on SRT failure Add missing fragmented mp4 support

2 participants