-
Notifications
You must be signed in to change notification settings - Fork 9
Add coupled thermal poroelasticity #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akva2
wants to merge
35
commits into
OPM:master
Choose a base branch
from
akva2:thermal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also when target Elasticity has not been defined yet. Changed: README.md corrections Added: COPYING
Mostly to get nicer log print. This includes implementing the virtual methods parse and parseMatProp in class PoroElasticity, and the getIntegrand method in SIMPoroElasticity which now inherits the parse method from SIMElasticity.
Simplified the other matrix-evaluation metods by multiplying the parameters outside. Removed the reimplementation of evalBou, the parent class method now does the job. Also the initElementBou methods are reimplemented empty, since solution vectors are not needed when evaluating the Neumann boundary conditions for linear problems. Flip sign of force balance equation.
Should make it very simple to add an alement matrix class for Newmark
Parameters beta and gamma hardcoded for now
…) also when target Elasticity has not been defined yet. Changed: README.md corrections Added: COPYING Added .gitignore
…e option -dyn[1|2] to run with standard Newmark or generalized alpha time integration
…mma. Changed: Removed method evalMassMatrix, use inherited formMassMatrix instead. Fixed/changed: Using matrix::multiply instead of the +=, -= and * operators in NewmarkMats::getRHSVector and check that the arrays have been allocated before trying to access them (avoiding crash during Neumann integration). Besides, The vector 'b' was used in a place where I assume it should have been 'vec'.
Fixed: Made Mats destructor virtual.
…ead of K*u Fixed: Made Mats destructor virtual.
We then only need the default constructor (convenience).
…ethod. Changed: Removed the mixedFormulation reimplementation. This integrand does not know whether mixed is used or not (both are possible).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a coupled thermo-poroelasticity SIM courtesy of @yaredwb.
It needs a lot of cleanup still, in particular to support newmark and such. But this works, is reasonable separate from the rest and cleanups can be done incrementally. I have rebased this for a year now, and I really do not want to do a big job yet another time so can we please merge this asap.
Based on (some version of) #5 and intended to be merged after that.