Support well completion quantities in ACTIONX #4855
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this we need to convert e.g. WWCTL__3 on well W1 to WWCTL:W1:3 for looking up the summary quantity and make sure that the func_type in ACTIONX is Well. In addition we check that number specifier in well completion quantity has the 3 characters used for the number and throw an expection with message similar to: Well completion quantity WWCTL_3 needs to have three consecutive characters that are a number or an underline character (e.g. WWCTL123:W1, WWCTL_23:W or WWCTL__3:W1)
blattms
added
the
manual:enhancement
Member
Author
|
jenkins build this please |
Member
Author
|
Seems like other simulators are less strict with the number representation. I might change that. |
Member
Author
|
jenkins build this please |
Member
Author
|
Strange. Jenkins just stopped during compiling opm-cmmon and marked it as failure |
blattms
force-pushed
the
feature/support-well-completion-quants-in-actionx
branch
from
75ab010 to
a565301
Compare
Member
Author
|
jenkins build this please |
E.g. we convert WWCTL_3 to WWCTL__3. This is done to prevent adding unuseful vectors because of ACTIONX.
This does not happen anymore as we fix abbreviated names during ACTIONX parsing.
blattms
force-pushed
the
feature/support-well-completion-quants-in-actionx
branch
from
a565301 to
c05006c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this we need to convert e.g. WWCTL__3 on well W1 to WWCTL:W1:3 for looking up the summary quantity and make sure that the func_type in ACTIONX is Well.
If the number in the well completion quantity WWCTL_3 has less than three consecutive characters then we fix this during parsing of ACTIONX
This is draft, because I need to check results and add tests.