OPM Keyword Reference activity bar icon, completion fix, and demo-deck tweak - #57
Merged
Conversation
Adds a dedicated view container with a monochrome OPM logo icon so the keyword docs view is no longer buried inside Explorer, and can be dragged to the secondary side bar independently of the outline view.
Curated supplemental keywords (STORE, AIM, CVTYPE, AMF, PREFT, ZCRITVIS, SPECHA, SPECHB, SPECHG, SPECHH) were merged into the runtime index without a sections array, even though several call sites (including the completion provider's item.detail) access entry.sections unconditionally. Hitting any of these 10 keywords during Array.map aborted the entire keyword-name completion list for every prefix, since a thrown callback discards all results. Default sections to [] when merging the supplement so every entry satisfies the sections: string[] contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sectionsarray, and the completion provider'sitem.detailaccessedentry.sectionsunconditionally — hitting any of these 10 keywords duringArray.mapdiscarded the entire completion list.