Skip to content

MinpvProcessor: opt-in thin-cell handling for edge-conformal grids - #1058

Open
hnil wants to merge 1 commit into
OPM:masterfrom
hnil:pr/minpv-thin-cells-optin
Open

MinpvProcessor: opt-in thin-cell handling for edge-conformal grids#1058
hnil wants to merge 1 commit into
OPM:masterfrom
hnil:pr/minpv-thin-cells-optin

Conversation

@hnil

@hnil hnil commented Aug 10, 2026

Copy link
Copy Markdown
Member

New defaulted parameter thin_cells_as_minpv (default false, behaviour unchanged). When enabled, active cells thinner than z_tolerance are treated like low-pore-volume cells throughout — removal, the column walk, NNC suppression and the gap check — and the merge branch runs for all removed cells, not only low-pv ones.

processEclipseFormat wires it to edge_conformal: edge-conformal grids select mergeMinPVCells and thin_cells_as_minpv so removed cells are merged geometrically and the grid stays topologically connected. No artificial faces via MINPV/PINCH NNCs (asserted), and pinch columns are treated as active gaps.

The requirement comes from the geomech/thermal stack: vertex-based discretizations need a conforming, connected grid, and NNCs across collapsed cells would create faces with no geometric counterpart.

Rebased onto master after #1051, which touched the same function. Two things were merged rather than taken wholesale:

All 82 opm-grid tests pass, including the 8 MinpvProcessor cases from #1051.

New defaulted parameter thin_cells_as_minpv (default false: behavior
unchanged, all existing tests pass). When enabled, active cells thinner than
z_tolerance are treated like low-pore-volume cells throughout (removal, the
column walk, NNC suppression and the gap check), and the merge branch runs
for all removed cells, not only low-pv ones.

processEclipseFormat wires it to edge_conformal: edge-conformal grids select
mergeMinPVCells and thin_cells_as_minpv so removed cells are merged
geometrically and the grid stays topologically connected -- no artificial
faces via MINPV/PINCH NNCs (asserted), and pinch columns are treated as
active gaps (pinchActive forced on).

This is the geomech/thermal stack requirement: vertex-based discretizations
need a conforming, connected grid; NNCs across collapsed cells would create
faces with no geometric counterpart.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@hnil hnil added the manual:enhancement This is an enhancement/improvent that needs to be documented in the manual label Aug 10, 2026
@hnil
hnil requested a review from blattms August 10, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:enhancement This is an enhancement/improvent that needs to be documented in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant