MinpvProcessor: opt-in thin-cell handling for edge-conformal grids - #1058
Open
hnil wants to merge 1 commit into
Open
MinpvProcessor: opt-in thin-cell handling for edge-conformal grids#1058hnil wants to merge 1 commit into
hnil wants to merge 1 commit into
Conversation
New defaulted parameter thin_cells_as_minpv (default false: behavior unchanged, all existing tests pass). When enabled, active cells thinner than z_tolerance are treated like low-pore-volume cells throughout (removal, the column walk, NNC suppression and the gap check), and the merge branch runs for all removed cells, not only low-pv ones. processEclipseFormat wires it to edge_conformal: edge-conformal grids select mergeMinPVCells and thin_cells_as_minpv so removed cells are merged geometrically and the grid stays topologically connected -- no artificial faces via MINPV/PINCH NNCs (asserted), and pinch columns are treated as active gaps (pinchActive forced on). This is the geomech/thermal stack requirement: vertex-based discretizations need a conforming, connected grid; NNCs across collapsed cells would create faces with no geometric counterpart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New defaulted parameter
thin_cells_as_minpv(defaultfalse, behaviour unchanged). When enabled, active cells thinner thanz_toleranceare treated like low-pore-volume cells throughout — removal, the column walk, NNC suppression and the gap check — and the merge branch runs for all removed cells, not only low-pv ones.processEclipseFormatwires it toedge_conformal: edge-conformal grids selectmergeMinPVCellsandthin_cells_as_minpvso removed cells are merged geometrically and the grid stays topologically connected. No artificial faces via MINPV/PINCH NNCs (asserted), and pinch columns are treated as active gaps.The requirement comes from the geomech/thermal stack: vertex-based discretizations need a conforming, connected grid, and NNCs across collapsed cells would create faces with no geometric counterpart.
Rebased onto master after #1051, which touched the same function. Two things were merged rather than taken wholesale:
kk_iter == dims_[2]check this branch used to add is redundant and is gone;pv > minpvvcomparison when the option is off, so the default path is unchanged rather than merely equivalent-looking.All 82 opm-grid tests pass, including the 8 MinpvProcessor cases from #1051.