Allow warnings from the settings service to expire#406
Merged
gleu merged 4 commits intoOPMDG:masterfrom Jan 21, 2026
Merged
Conversation
Krysztophe
approved these changes
Jan 16, 2026
| The Critical thresholds is ignored. | ||
|
|
||
| A Critical is raised if at least one parameter changed. | ||
| Warning is raised when the time since configuration change is less than the |
Collaborator
There was a problem hiding this comment.
Nitpicking: since configuration change or since the 1st time a change was detected?
Collaborator
Author
There was a problem hiding this comment.
Since the first time this particular change was detected.
blogh
force-pushed
the
setting_service_timeout
branch
from
5b555f3 to
02d9afe
Compare
Collaborator
Author
|
rebase |
Collaborator
|
Works for me! Thanks! |
Collaborator
|
Juste merged as it is definitely working. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch Warning is raised when the time since configuration change
is less than the warning threshold. Obviously these alerts will disappear from
themselves once enough time has passed. This doesn't apply for configuration
changes with pending restart warnings.
Eg:
Closes #405