Skip to content

feat: enable autocomplete for one-time-code #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontenegro merged 5 commits into from
Mar 11, 2026
Merged

feat: enable autocomplete for one-time-code #2749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb69d01
feat: enable autocomplete for one-time-code
olivier-maury Feb 19, 2026
7ff0c9a
Merge branch 'main' into patch-2
olivier-maury Mar 3, 2026
00b397c
Code review changes: one-time code fields will behave consistently
olivier-maury Mar 3, 2026
8ead023
Merge branch 'main' into patch-2
olivier-maury Mar 6, 2026
1ba948b
Merge branch 'main' into patch-2
amontenegro Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...count-settings/pages/confirm-deactivate-account/confirm-deactivate-account.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,9 @@
>
<input
id="twoFactorCode"
type="text"
autocomplete="one-time-code"
inputmode="numeric"
name="totp"
aria-labelledby="2fa-input-label"
formControlName="twoFactorCode"
matInput
Expand Down
12 changes: 10 additions & 2 deletions ...k/two-factor-authentication-form/two-factor/two-factor-authentication-form.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<div class="input-container">
<mat-label
class="orc-font-small-print"
for="totp"
i18n="@@ngOrcid.signin.2fa.label"
[ngClass]="{
error: isVerificationCodeInvalid
Expand All @@ -20,7 +21,11 @@
formControlName="verificationCode"
cdkFocusInitial
appTrim
autocomplete="off"
autocomplete="one-time-code"
Comment thread
olivier-maury marked this conversation as resolved.
id="totp"
inputmode="numeric"
name="totp"
type="text"
/>
</mat-form-field>
<ng-container *ngIf="!recoveryCode">
Expand Down Expand Up @@ -119,7 +124,10 @@
#inputRecoveryCode
formControlName="recoveryCode"
appTrim
autocomplete="off"
autocomplete="one-time-code"
inputmode="numeric"
name="totp"
type="text"
/>
</mat-form-field>
<ng-container *ngIf="recoveryCode">
Expand Down
6 changes: 5 additions & 1 deletion src/app/two-factor-setup/components/two-factor-enable/two-factor-enable.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,11 @@
#inputVerificationCode
formControlName="verificationCode"
appTrim
autocomplete="off"
autocomplete="one-time-code"
id="totp"
inputmode="numeric"
name="totp"
type="text"
data-cy="verification-code-input"
/>
<mat-hint align="end"
Expand Down
Loading